Skip to content
This repository has been archived by the owner on Sep 24, 2022. It is now read-only.

Permissions command #106

Closed
weeryan17 opened this issue May 16, 2019 · 4 comments · Fixed by #123
Closed

Permissions command #106

weeryan17 opened this issue May 16, 2019 · 4 comments · Fixed by #123
Assignees
Labels
module: management status: approved to work on Issues and pull requests labelled with this have been cleared to start work on
Milestone

Comments

@weeryan17
Copy link
Member

So I just realized we don't have a permissions command yet, and that's kind of important.
We need to account for both permission modes via commands, and probably have a way to test perms.
As permissions are complicated we're open to ideas for command structure.

@weeryan17 weeryan17 added this to the Alpha milestone May 16, 2019
@weeryan17 weeryan17 added this to To Do in CascadeBot Alpha via automation May 16, 2019
@binaryoverload
Copy link
Member

I'm thinking we do something similar to how GroupManager structures their commands. Now there's two ways of doing this: one way is to have separate commands for editing users, groups and other items; the other way is to, like in group manager, have a completely separate command for each action. I personally always found a command for every option quite confusing so I would prefer to do it the former way i.e. have a separate for editing users, groups and executing other actions.

@weeryan17
Copy link
Member Author

I'm actually thinking maybe one giant permissions command might not be too bad this time around, and one of the main issues we had with that was in code, and now that we have sub commands the code shouldn't be too bad. I also like the different group ans user commands idea, but we need to find a way to preface those commands so your not just running ;user as that's very ambiguous.

@binaryoverload
Copy link
Member

Yeah I hear you, I'm gonna say let's talk about this more in the meeting

@binaryoverload binaryoverload added the status: waiting on meeting A issue or PR that needs further discussion before moving forward label May 21, 2019
@weeryan17 weeryan17 removed the status: waiting on meeting A issue or PR that needs further discussion before moving forward label May 26, 2019
@weeryan17
Copy link
Member Author

after talking about it during the meeting we decided on doing module based permission command
example
;userperms <add/remove/etc>
;groupperms <add/remove/etc>
;misc

@weeryan17 weeryan17 self-assigned this May 26, 2019
@weeryan17 weeryan17 added status: approved to work on Issues and pull requests labelled with this have been cleared to start work on and removed status: planning labels May 28, 2019
@weeryan17 weeryan17 moved this from To Do to In progress in CascadeBot Alpha Jun 1, 2019
@binaryoverload binaryoverload added status: pr in progress status: approved to work on Issues and pull requests labelled with this have been cleared to start work on and removed status: approved to work on Issues and pull requests labelled with this have been cleared to start work on status: pr in progress labels Jun 5, 2019
CascadeBot Alpha automation moved this from In progress to Done Jun 20, 2019
@Ikinon Ikinon moved this from Done to Closed in CascadeBot Alpha Jul 6, 2019
@Ikinon Ikinon moved this from Closed to Done in CascadeBot Alpha Jul 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
module: management status: approved to work on Issues and pull requests labelled with this have been cleared to start work on
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants