This repository has been archived by the owner on Sep 24, 2022. It is now read-only.
Feature/permissions command #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I still have a lot of cleanup to do.
binaryoverload
suggested changes
Jun 15, 2019
...in/java/org/cascadebot/cascadebot/commands/management/permission/PermissionCommandUtils.java
Outdated
Show resolved
Hide resolved
...in/java/org/cascadebot/cascadebot/commands/management/permission/PermissionCommandUtils.java
Outdated
Show resolved
Hide resolved
...in/java/org/cascadebot/cascadebot/commands/management/permission/PermissionCommandUtils.java
Outdated
Show resolved
Hide resolved
...in/java/org/cascadebot/cascadebot/commands/management/permission/PermissionCommandUtils.java
Outdated
Show resolved
Hide resolved
binaryoverload
suggested changes
Jun 19, 2019
There was a problem hiding this comment.
Overall a pretty good PR. Most of what I've requested is consistency with using the string format variant of replyType i.e replySuccess(String, Object...), replyDanger(String, Object...) etc
Can you please also go over and format all the files? There's some if(s hanging about.
...a/org/cascadebot/cascadebot/commands/management/permission/GroupPermissionAddSubCommand.java
Show resolved
Hide resolved
...a/org/cascadebot/cascadebot/commands/management/permission/GroupPermissionAddSubCommand.java
Show resolved
Hide resolved
...rg/cascadebot/cascadebot/commands/management/permission/GroupPermissionCreateSubCommand.java
Outdated
Show resolved
Hide resolved
.../org/cascadebot/cascadebot/commands/management/permission/GroupPermissionInfoSubCommand.java
Show resolved
Hide resolved
.../cascadebot/cascadebot/commands/management/permission/GroupPermissionLinkRoleSubCommand.java
Show resolved
Hide resolved
...a/org/cascadebot/cascadebot/commands/management/permission/UserPermissionTestSubCommand.java
Outdated
Show resolved
Hide resolved
...a/org/cascadebot/cascadebot/commands/management/permission/UserPermissionTestSubCommand.java
Outdated
Show resolved
Hide resolved
...a/org/cascadebot/cascadebot/commands/management/permission/UserPermissionTestSubCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cascadebot/cascadebot/data/objects/GuildPermissions.java
Show resolved
Hide resolved
src/main/java/org/cascadebot/cascadebot/utils/PermissionCommandUtils.java
Show resolved
Hide resolved
.../org/cascadebot/cascadebot/commands/management/permission/GroupPermissionListSubCommand.java
Outdated
Show resolved
Hide resolved
binaryoverload
approved these changes
Jun 20, 2019
Let's get this merged as finding out why it's not saving is probably going to be a pain. besides getting it merged now allows lang stuff to happen |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Added/Changed
Permissions commands.
Some utils for said permissions commands.
TODO
I'm dong a draft pr so I can get feedback on this before I finish up completely.
Closes #106