Skip to content
This repository has been archived by the owner on Sep 24, 2022. It is now read-only.

Stat[u]s Command #130

Merged
merged 15 commits into from
Jun 24, 2019
Merged

Stat[u]s Command #130

merged 15 commits into from
Jun 24, 2019

Conversation

JamesHawkinss
Copy link
Contributor

@JamesHawkinss JamesHawkinss commented Jun 16, 2019

Pull request

  • I have read and agreed to the code of conduct.
  • I have read and complied with the contributing guidelines.
  • What I'm implementing was assigned to me or was not being worked on and is a somewhat requested feature. For reference see our GitHub projects.
  • I have tested all of my changes.

Added/Changed

Added Status Command

I have made this a draft PR because I don't know if y'all even want this command, and I need feedback on what else to add to it.

Closes #129

Copy link
Member

@binaryoverload binaryoverload left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've accidentally included changes from your other PR, try and make a branch for next time

@JamesHawkinss
Copy link
Contributor Author

You've accidentally included changes from your other PR, try and make a branch for next time

Oops, sorry

@JamesHawkinss JamesHawkinss marked this pull request as ready for review June 16, 2019 10:31
binaryoverload
binaryoverload previously approved these changes Jun 16, 2019
Copy link
Member

@binaryoverload binaryoverload left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Can't be merged until #128 is merged

@JamesHawkinss
Copy link
Contributor Author

@binaryoverload #128 has been merged.

@binaryoverload binaryoverload added this to To Do in CascadeBot Alpha via automation Jun 20, 2019
@binaryoverload binaryoverload added this to the Alpha milestone Jun 20, 2019
@binaryoverload binaryoverload moved this from To Do to Being Reviewed in CascadeBot Alpha Jun 20, 2019
@cascadediscordbot
Copy link
Member

Meeting discussion around this PR

This command is currently closest to a "stats" command so it should be changed from StatusCommand to StatsCommand. To go along with this, here are some changes you can implement:

  • Remove JDA and CascadeBot version, these will be added in a future info command
  • Add number of guilds
  • Add number of active guilds (Number of guilds in our cache)
  • Add number of active voice channels
  • Add memory usage (From the Runtime object)
  • Add CPU load (From the OperatingSystemMXBean object)

@JamesHawkinss JamesHawkinss changed the title Status Command Stat[u]s Command Jun 23, 2019
@JamesHawkinss
Copy link
Contributor Author

@binaryoverload @weeryan17 did all the stuff that cascade told me to

CascadeBot Alpha automation moved this from Being Reviewed to Approved Jun 24, 2019
@weeryan17 weeryan17 merged commit cb037b4 into CascadeBot:dev Jun 24, 2019
CascadeBot Alpha automation moved this from Approved to Done Jun 24, 2019
@JamesHawkinss JamesHawkinss deleted the feature/status-command branch July 5, 2019 19:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Status Command
4 participants