Skip to content
This repository has been archived by the owner on Sep 24, 2022. It is now read-only.

Feature/bancommand #46

Merged
merged 12 commits into from
Mar 2, 2019
Merged

Feature/bancommand #46

merged 12 commits into from
Mar 2, 2019

Conversation

JamesHawkinss
Copy link
Contributor

@JamesHawkinss JamesHawkinss commented Feb 22, 2019 •
edited
Loading

Pull request

  • I have read and agreed to the CODE OF CONDUCT.
  • What I'm implementing was assigned to me or was not being worked on and is a somewhat requested feature. For reference see our trello.
  • I have tested all of my changes.
  • I have followed the style of the rest of the project.

Added/Changed

What did you add and/or change for this.

Feature

If this is a new feature, why should we add it to the bot.

@JamesHawkinss
Copy link
Contributor Author

Ban command

@binaryoverload
Copy link
Member

Waiting on #44

@binaryoverload binaryoverload added the status: waiting on pr Indicates this PR is waiting for another PR to go through label Feb 23, 2019
@binaryoverload binaryoverload added this to Being Reviewed in CascadeBot Alpha Feb 23, 2019
@binaryoverload binaryoverload added this to the Alpha milestone Feb 23, 2019
@Ikinon
Copy link
Contributor

Ikinon commented Feb 23, 2019

Maybe add checks to make sure the user does not ban themselves or try to ban the bot

binaryoverload
binaryoverload suggested changes Feb 24, 2019
View reviewed changes
Copy link
Member

@binaryoverload binaryoverload left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add checks to make sure the user does not ban themselves or try to ban the bot

Do this please

@weeryan17 weeryan17 removed the status: waiting on pr Indicates this PR is waiting for another PR to go through label Feb 24, 2019
@binaryoverload binaryoverload mentioned this pull request Feb 28, 2019
Closed
@JamesHawkinss
Copy link
Contributor Author

Maybe add checks to make sure the user does not ban themselves or try to ban the bot

Do this please

Done

@binaryoverload binaryoverload merged commit 67fc94f into CascadeBot:dev Mar 2, 2019
CascadeBot Alpha automation moved this from Being Reviewed to Done Mar 2, 2019
@binaryoverload binaryoverload modified the milestone: Alpha Mar 31, 2019
@binaryoverload binaryoverload mentioned this pull request Mar 31, 2019
Closed
4 tasks
@JamesHawkinss JamesHawkinss deleted the feature/bancommand branch April 5, 2019 18:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@binaryoverload binaryoverload binaryoverload requested changes

@weeryan17 weeryan17 weeryan17 approved these changes

Assignees
No one assigned
Labels
module: moderation status: on hold
Projects
No open projects
CascadeBot Alpha
  
Done
Milestone
Alpha
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JamesHawkinss @binaryoverload @Ikinon @weeryan17 @cascadediscordbot