Timestamps are assigned to pg_search_documents in multisearch rebuild #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I left a couple comments on your commit. Could you update it? |
|
Edits look good. Thanks for the merge. Overall kudos for what's been a very useful gem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails' timestamps migration helper now defaults to :null => false. This previously caused the multisearch rebuild rake tast to throw a not-null violation as it hasn't been assigning timestamps.
This simply adds the assignment of these timestamps, as the current time, to the sql injection statement in the rake task.
Alternative solution could be to amend the migration to create null-friendly timestamp columns, however assigning timestamps from the beginning seems the better way to go.
Relates to this issue:
#27