Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSC control of client Pause/Resume does not function #304

Closed
amwtech opened this issue Jan 8, 2023 · 2 comments
Closed

OSC control of client Pause/Resume does not function #304

amwtech opened this issue Jan 8, 2023 · 2 comments
Labels

Comments

@amwtech
Copy link
Contributor

amwtech commented Jan 8, 2023

Client versions with the issue include 2.0.8, 2.0.9, 2.2
Operating Systems: Windows, MacOS, Linux

When a remote control enabled rundown recieves a OSC message with address /control/pause the command is ignored.

The reason is the code to add the pause command to the list of recognised commands is missing from file rundowntreewidget.cpp

The missing code is shown below:

/* Missing PAUSE connection - version 2.0.9 client branch */
QString pauseControlFilter = Osc::DEFAULT_PAUSE_RUNDOWN_CONTROL_FILTER;
this->pauseControlSubscription = new OscSubscription(pauseControlFilter, this);
QObject::connect(this->pauseControlSubscription, SIGNAL(subscriptionReceived(const QString&, const QList<QVariant>&)),
              this, SLOT(pauseControlSubscriptionReceived(const QString&, const QList<QVariant>&)));
/* Missing PAUSE connection - version 2.2.0 client branch */
QString pauseControlFilter = Osc::RUNDOWN_CONTROL_PAUSE_FILTER;
this->pauseControlSubscription = new OscSubscription(pauseControlFilter, this);
QObject::connect(this->pauseControlSubscription, SIGNAL(subscriptionReceived(const QString&, const QList<QVariant>&)),
              this, SLOT(pauseControlSubscriptionReceived(const QString&, const QList<QVariant>&)));

Add this code to function void RundownTreeWidget::configureOscSubscriptions(), for example starting at line 1804 of the version 2.2 client file set.

@Julusian
Copy link
Member

Fix applied in cb28e23
I havent tested it, hopefully it still works

@amwtech
Copy link
Contributor Author

amwtech commented Dec 18, 2023

Tested on Mac and Windows client build. Operates correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants