Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.10 CINF broken #517

Closed
jesperstarkar opened this issue Dec 4, 2016 · 2 comments
Closed

2.10 CINF broken #517

jesperstarkar opened this issue Dec 4, 2016 · 2 comments

Comments

@jesperstarkar
Copy link
Contributor

The implementation of CINF seems to be nearly the same in 2.0.7 and 2.1.0, but 2.1.0 still produces another result than 2.0.7, and some cases aren't possible to sucessfully do with CINF in 2.1.0

  • With CINF you pass a filename, and CINF then searches recursivly through all folders, matching the file-name against all files, and reports the file attributes for all files with a matching file name.
  • In 2.0.7, having two files with the same file name in different folders returns two lines of results.
  • In 2.1.0, having the same two files with matching file names in the same sub folders, return only the first matching result.
  • The only difference in logic bewtween 2.0.7 and 2.1.0 I can see is:

auto file = path.replace_extension(L"").filename(); (2.0.7)

vs.

auto file = path.replace_extension(L"").filename().wstring(); (2.1.0)

This is a to be considered a breaking bug, as with the current 2.1.0 result you simply can't access CINF-info from sub folders.

I suggest that the new implementation should allow for passing in subfolder/subsubfolder/filename and match agains both path and file, allways producing a single line of result, never listing an array of multiple files with the same file-name in different sub folder.

@HellGore
Copy link
Contributor

Fixed

@jesperstarkar
Copy link
Contributor Author

Thank you, work well now! :)

ronag pushed a commit to nxtedition/casparcg that referenced this issue Jan 16, 2018
ronag pushed a commit to nxtedition/casparcg that referenced this issue Jan 16, 2018
Former-commit-id: f0af280
Former-commit-id: 2444ddabcfa304a584f553790046e75839c888ab [formerly ab7a214]
Former-commit-id: 6f2ddcf565e21db9804c98cec01ea47d7809d0a6
ronag pushed a commit to nxtedition/casparcg that referenced this issue Jan 16, 2018
Former-commit-id: f0af280
Former-commit-id: 2444ddabcfa304a584f553790046e75839c888ab [formerly ab7a214]
Former-commit-id: 6f2ddcf565e21db9804c98cec01ea47d7809d0a6
Former-commit-id: b612e713606e0b1496bdcce1bd908a819888468b [formerly 5aa723b]
Former-commit-id: 11b419db87b7e12a8ae3566a927eff71850daed0
ronag pushed a commit that referenced this issue Feb 7, 2018
ronag pushed a commit that referenced this issue Feb 21, 2018
Former-commit-id: e68d741 [formerly 5aba4d2]
Former-commit-id: 6de8a0e
ronag pushed a commit that referenced this issue Feb 21, 2018
Former-commit-id: 94049ef [formerly 94049ef [formerly 3e13889]]
Former-commit-id: 1897782
Former-commit-id: 2506636
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants