feat(screen): Optionally specify absolute coordinates and size of windows #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #115 #487 #995
This allows specifying x,y,width,height and always-on-top for a screen consumer.
x and y are an offset relative to the screen selected via screen-index
width and height override the channel format if set. If only one of them is set then the aspect_ratio property is respected to calculate the window size.
These coordinates and dimensions only have effect when the consumer is windowed
Additionally, the aspect_ratio and stretch properties were broken by #966 and now work again.
Some linux window managers were always maximising any screen consumer windows due to them being created at screen size, then the size changed to be correct. It is now set correct when created
Tested on debian 10 (gnome 3) with intel gpu and on windows 10 with intel gpu
One quirks that I shall document on the wiki once this is accepted is that when the consumer is fullscreen and always-on-top, the taskbar, startmenu and alt-tab overlay will still draw on top.