Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audio on NTSC system #1227

Closed
wants to merge 3 commits into from
Closed

Conversation

ducthiem90
Copy link
Contributor

@ducthiem90 ducthiem90 commented Aug 7, 2019

I found problem with audio on ntsc system. And propose a solution to fix it

@Julusian
Copy link
Member

This needs a thorough review and test, but I just found a painful bug in this area in 2.1NRK (and remembered this PR existed touching the same area).

But a question; as you are always setting the tag to nullptr, how does this work to identify the streams?

The basic problem with the tag concept, is that routes do not modify this tag which can cause audio to get really messed up if there are more than one route of one source into a channel.

@dotarmin dotarmin added this to the v2.3.0 LTS milestone Apr 7, 2020
@dotarmin dotarmin modified the milestones: v2.3.0 LTS, v2.3.1 LTS Apr 15, 2020
@jesperstarkar
Copy link
Contributor

@ducthiem90 We are looking at merging this now. Can you please do a write-up of the core issue and the fix, to better explain what we should look for and verify?

@ducthiem90
Copy link
Contributor Author

@ducthiem90 We are looking at merging this now. Can you please do a write-up of the core issue and the fix, to better explain what we should look for and verify?

Sorry. It is not ready to merge. I will check it and find another solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants