Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for attachments #30

Merged
merged 8 commits into from
Oct 14, 2016

Conversation

obaid
Copy link
Contributor

@obaid obaid commented Oct 14, 2016

  • Added support for handling incoming notifications that aren't messages
  • Added support for handling incoming attachments

@coveralls
Copy link

coveralls commented Oct 14, 2016

Coverage Status

Coverage decreased (-0.4%) to 99.562% when pulling 2b36697 on obaid:support-for-attachments into 20b2785 on CasperLaiTW:master.

@CasperLaiTW
Copy link
Owner

CasperLaiTW commented Oct 14, 2016

Thank you for your PR.
I found the ReceiveMessage __construct parameters so complicated. (#28)
And I am already started to refactor it.
Next release will change construct params.

@CasperLaiTW CasperLaiTW merged commit 7964d54 into CasperLaiTW:master Oct 14, 2016
@obaid
Copy link
Contributor Author

obaid commented Oct 14, 2016

@CasperLaiTW thanks for accepting the PR.

Do you have a roadmap document that we can share? I am actively developing an application using this library so it would be great to know what changes are upcoming.

@CasperLaiTW
Copy link
Owner

@obaid. First, thanks for you using the library on your project
I am sorry. The project is maintained on my free time, so I didn't plan any roadmap or schedule.
But next release do not update any getter function or interface, so do not worry about compatibility.

@CasperLaiTW
Copy link
Owner

I check facebook messenger platform changelog, they are release new version.
Maybe I can plan some feature and create milestone on github.
Hope to help for you.

The v1.1 is almost done, maybe into plan v1.2

If you have any feature or enhancement idea, please create issue to me.
I will use my free time to implement.

@obaid
Copy link
Contributor Author

obaid commented Oct 14, 2016

I completely understand that. Perhaps, I will continue to add features / bug fixes as I go with my development effort and I will keep submitting PR requests to merge them in.

@obaid obaid deleted the support-for-attachments branch October 14, 2016 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants