Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use periodic table widget #143

Merged
merged 4 commits into from
Sep 26, 2020
Merged

Use periodic table widget #143

merged 4 commits into from
Sep 26, 2020

Conversation

CasperWA
Copy link
Owner

@CasperWA CasperWA commented Sep 14, 2020

Closes #48

Use the Periodic Table widget from OSSCAR as input of "Elements".
Using "states" it can act as input for both including and excluding.

Issues left to solve:

  • Update published version of widget (to PyPI) to newest develop version.
  • Fix basic bugs in widget (trailing ;, etc.)
  • Allow changing the layout (being able to set HTML CSS width, height, etc.)

@CasperWA CasperWA force-pushed the close_48_periodic-table branch 2 times, most recently from c123dcb to d8b4d6a Compare September 24, 2020 17:04
@CasperWA CasperWA force-pushed the close_48_periodic-table branch 2 times, most recently from ca1800e to 92b041a Compare September 26, 2020 17:55
Wrap PTableWidget in a custom widget.
This makes it easier to use in FilterInputs as well as to toggle HAS ANY
or HAS ALL filterings.

Wrap `collect_value` in a try-except in order to properly raise if an
exception occurs.

Allow the filter parser to return operators.
OPERATORS_MAP has become a fallback, with the default operator being
`""`.
Use CIF and PDB conversions from `optimade` package.
black is only used in pre-commit, where it is downloaded and installed
separately.
@CasperWA CasperWA merged commit c2976ee into develop Sep 26, 2020
@CasperWA CasperWA deleted the close_48_periodic-table branch September 26, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add periodic table widget for inputs of "Elements"
1 participant