Properly implement button_style parameter in button's HTML
#175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new button_style variable was not supplied in several calls to the
`format()` function when setting the download button's HTML.
This also adds an automatic default for the `ButtonStyle` Enum
("DEFAULT").
A warning will be logged (and shown in the log under normal conditions)
that the supplied button_style value was wrong, and it has been set to
"DEFAULT", if it was wrong.
button_style type of ButtonStyle is also allowed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #173
The HTML string defining the download button was updated with the
button_stylevariable, but it was not always set, leading to silent errors.The
ButtonStyleEnumhas been given a fallback to ´"DEFAULT"as well (when using theButtonStyle[name]` style).Initialization properly handles the case where the passed
button_styleparameter is of typeButtonStyle.