Don't query default nsites and nelements values #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to minimize query parameters in a given query. The custom IntRangeSlider widget implements a `get_value()` function that is used instead of getting the `value` attribute, which will return `(None, None)` if the values are equal to the `min` and `max` attributes, respectively.
CasperWA
force-pushed
the
dont_query_default_nsites_nelements
branch
from
c9fc16e
to
329e01b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is inspired by issue #125, in the sense that COD was failing to handle
nsites, and this is added by default even if the user has not changed it. There is no need to add a query for a non-filter. Hence, this PR will make sure to not addnsitesandnelementsto the query filter if they are equal to their initial values.A custom
IntRangeSliderwidget is implemented to handle returning aNonevalue.The custom
IntRangeSliderwidget simply implements aget_value()function that is used instead of getting thevalueattribute, which. It will return(None, None)if the values are equal to theminandmaxattributes, respectively. If only one value is altered the other will beNone.