Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to change grid widths of provider sub-widgets #188

Merged
merged 2 commits into from
Oct 26, 2020

Conversation

CasperWA
Copy link
Owner

Add width_ratio and width_space parameters to OptimadeQueryProviderWidget.
These parameters allows the user to specify the number of grid columns used to layout the dropdown and informational sub-widgets.
width_space indicates how many columns should be spaced in between the two sub-widgets.

The default is width_ratio=(10, 21) and width_space=1, meaning the total number of columns are 31 (sum of width_ratio) and the dropdown sub-widget spans 10 columns, while the informational sub-widget spans 20 columns (21 - the value of width_space, which is 1).

@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #188 into develop will decrease coverage by 0.01%.
The diff coverage is 30.76%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #188      +/-   ##
===========================================
- Coverage    35.99%   35.98%   -0.02%     
===========================================
  Files           17       17              
  Lines         2128     2137       +9     
===========================================
+ Hits           766      769       +3     
- Misses        1362     1368       +6     
Flag Coverage Δ
#optimade-client 35.98% <30.76%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade_client/query_provider.py 35.89% <30.76%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46f9b1c...31d350b. Read the comment docs.

@CasperWA CasperWA merged commit 218af21 into develop Oct 26, 2020
@CasperWA CasperWA deleted the change_provider_ratio branch October 26, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant