Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sort order width #226

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Fix sort order width #226

merged 2 commits into from
Nov 20, 2020

Conversation

CasperWA
Copy link
Owner

The sort order button is a fixed width, which will clash if the CSS is changed.
This has already been observed using the materialscloud template.

This PR also adds a --template option to the optimade-client CLI, where one can pass a Voilà template.

@CasperWA CasperWA added the bug Something isn't working label Nov 20, 2020
@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #226 (ba46990) into develop (a7a3e2e) will increase coverage by 0.06%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #226      +/-   ##
===========================================
+ Coverage    35.82%   35.89%   +0.06%     
===========================================
  Files           18       18              
  Lines         2272     2276       +4     
===========================================
+ Hits           814      817       +3     
- Misses        1458     1459       +1     
Flag Coverage Δ
optimade-client 35.89% <75.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade_client/subwidgets/sort_selector.py 34.09% <ø> (ø)
optimade_client/cli/run.py 95.65% <75.00%> (-1.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a3e2e...ba46990. Read the comment docs.

@CasperWA CasperWA merged commit ba46990 into develop Nov 20, 2020
@CasperWA CasperWA deleted the fix_sort-order-width branch November 20, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant