Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dropdowns on value changes (not index) #358

Merged
merged 4 commits into from
Oct 12, 2021

Conversation

CasperWA
Copy link
Owner

@CasperWA CasperWA commented Oct 12, 2021

Fixes #357

Avoid using the private method _get_grouping_label_value() for ipywidgets_extended.DropdownExtended, and use the label and value attributes instead.

Note: The latest version (v1.1.1) of ipywidgets_extended should be the minimum requirement prior to this being merged.
Edit: With the merge of #359 this is now the case.

@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #358 (ffeae6e) into develop (68e2df5) will decrease coverage by 0.01%.
The diff coverage is 16.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #358      +/-   ##
===========================================
- Coverage    35.26%   35.24%   -0.02%     
===========================================
  Files           19       19              
  Lines         2402     2403       +1     
===========================================
  Hits           847      847              
- Misses        1555     1556       +1     
Flag Coverage Δ
optimade-client 35.24% <16.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade_client/subwidgets/provider_database.py 15.82% <16.66%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68e2df5...ffeae6e. Read the comment docs.

@CasperWA CasperWA force-pushed the fix-357-dropdown-header-value branch from 5886dca to ffeae6e Compare October 12, 2021 09:09
@CasperWA CasperWA merged commit c140138 into develop Oct 12, 2021
@CasperWA CasperWA deleted the fix-357-dropdown-header-value branch October 12, 2021 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Never choose a "group" value in dropdowns
1 participant