Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ouptut: Add annotation and deprecation messages #185

Merged

Conversation

josephsnyder
Copy link
Contributor

When adding an attribute for the deprecation of a C++ object, check to
see if there is a deprecation message and add that as a new entry to the
XML.

@josephsnyder josephsnyder force-pushed the add_deprecation_message_processing branch from a227c0f to cc3f7c7 Compare December 18, 2020 16:17
Copy link
Member

@bradking bradking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The castxml format version number in OutputStartXMLTags needs to have its version updated from $epic.2.0 to $epic.2.1.

src/Output.cxx Outdated Show resolved Hide resolved
test/CMakeLists.txt Outdated Show resolved Hide resolved
src/Output.cxx Outdated Show resolved Hide resolved
@josephsnyder josephsnyder force-pushed the add_deprecation_message_processing branch from cc3f7c7 to 20c8568 Compare December 21, 2020 22:06
@josephsnyder josephsnyder marked this pull request as ready for review January 5, 2021 18:48
When there is an annotation attribute, add its message in a dedicated
XML attribute.  Do this only for the CastXML formats.
When there is a deprecation attribute with a message, add it in a
dedicated XML attribute.  Do this only for the CastXML formats.
@bradking bradking force-pushed the add_deprecation_message_processing branch from 20c8568 to d515496 Compare January 6, 2021 17:38
@bradking bradking changed the title Add checking for deprecation message. Ouptut: Add annotation and deprecation messages Jan 6, 2021
@bradking
Copy link
Member

bradking commented Jan 6, 2021

@josephsnyder thanks. I updated your branch to revise the history, to use src/clang-format.bash to format the code, and to update the test expected output for the revised layout. Please fetch and reset your checkout (no push needed).

@bradking bradking merged commit d515496 into CastXML:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants