Fix an issue, reported via email, where a client connection breaks be… #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fore the full proxy bytes are received, in such a way as to trigger a rapidly spinning infinite loop, leading to undue CPU usage.
Castaglia
commented
Nov 20, 2022
| @@ -255,21 +255,21 @@ static int readv_sock(int sockfd, const struct iovec *iov, int count) { | |||
|
|
|||
| return -1; | |||
| } | |||
| } | |||
There was a problem hiding this comment.
This turned out to be the culprit: misleading indentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fore the full proxy bytes are received, in such a way as to trigger a rapidly spinning infinite loop, leading to undue CPU usage.