Skip to content

Commit

Permalink
sata_fsl: fix error handling of irq_of_parse_and_map
Browse files Browse the repository at this point in the history
commit aad0b624129709c94c2e19e583b6053520353fa8 upstream.

irq_of_parse_and_map() returns 0 on error (the result is unsigned int),
so testing for negative result never works.

Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Zefan Li <lizefan@huawei.com>
  • Loading branch information
dtor authored and CastagnaIT committed Apr 2, 2017
1 parent 22037f8 commit 23558b6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/ata/sata_fsl.c
Original file line number Diff line number Diff line change
Expand Up @@ -1426,7 +1426,7 @@ static int sata_fsl_probe(struct platform_device *ofdev)
host_priv->csr_base = csr_base;

irq = irq_of_parse_and_map(ofdev->dev.of_node, 0);
if (irq < 0) {
if (!irq) {
dev_err(&ofdev->dev, "invalid irq from platform\n");
goto error_exit_with_cleanup;
}
Expand Down

0 comments on commit 23558b6

Please sign in to comment.