Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate zh tw v0.0.1 #1000

Merged
merged 3 commits into from Dec 30, 2020
Merged

Translate zh tw v0.0.1 #1000

merged 3 commits into from Dec 30, 2020

Conversation

JuenTingShie
Copy link
Contributor

Check if this PR fulfills these requirements:

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Feature change (non-breaking change which change behaviour of an existing functionality)
  • Improvement (non-breaking change which improve functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Translate

Description

I add zh_TW translate to this repo, please have a see.
and also, CONTRIBUTING document is not found, maybe need to update?

In case of Feature change / Breaking change:

Describe the current behavior

Describe the new behavior

Screenshots (if appropriate):

@JuenTingShie JuenTingShie mentioned this pull request Dec 28, 2020
Open
CastagnaIT
CastagnaIT requested changes Dec 29, 2020
View reviewed changes
Copy link
Owner

@CastagnaIT CastagnaIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi thanks for the new translation!
only minor thing to fix/check

resources/language/resource.language.zh_tw/strings.po Outdated Show resolved Hide resolved
resources/language/resource.language.zh_tw/strings.po Outdated Show resolved Hide resolved
resources/language/resource.language.zh_tw/strings.po Outdated Show resolved Hide resolved
resources/language/resource.language.zh_tw/strings.po Show resolved Hide resolved
@JuenTingShie
Translate zh tw v0.0.2
b3c160e 
Minor change mention from here #1000 (review)
@CastagnaIT CastagnaIT merged commit cdcf04e into CastagnaIT:master Dec 30, 2020
@JuenTingShie JuenTingShie deleted the translate_zh_tw_v0.0.1 branch December 30, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CastagnaIT CastagnaIT CastagnaIT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JuenTingShie @CastagnaIT