Migration to HTTP/2 network protocol #1172
Conversation
CastagnaIT
force-pushed
the
http2
branch
3 times, most recently
from
c6e59d9
to
9a77c5b
Compare
CastagnaIT
force-pushed
the
http2
branch
2 times, most recently
from
0a79771
to
5bf0865
Compare
CastagnaIT
added
the
Testers needed
|
I tested the login in a clean installation of Kodi 19.1 with the email and password and it worked without any problem without the need for using the authentication key, I'm using windows 10. |
|
good to hear! |
CastagnaIT
force-pushed
the
http2
branch
4 times, most recently
from
3acf153
to
7724fed
Compare
|
hi @betatester3016 I need to know a simply thing, if the standard login (user+password) works without raise error "incorrect password", On systems:
|
I confirm being able to log in with username and password on both O.S. when using: plugin.video.netflix_1.16.2+matrix.1_20210718_http2_t1 The results can be replicated by uninstalling and reinstalling the provided add on. |
|
Thank you i am testing/using this version from about 1 month, and to me works good, i do not see wrong behaviours/errors |
|
Android 9 = Nvidia Shield TV No Problem with user+password login = no authentication key = all OK |
|
thanks for the report i think to include this on next release if i will find a bit of time |
CastagnaIT
removed
the
Testers needed
Currently there is no way to enable TCP KeepAlive directly on httpx module
Currently there is no way to enable TCP KeepAlive directly on httpx module ref. PR:#1172
Currently there is no way to enable TCP KeepAlive directly on httpx module ref. PR:#1172
Check if this PR fulfills these requirements:
Types of changes
Description
This is currently experimentalLast year the website is migrated to the HTTP/2 protocol
currently the web session is managed by the Requests module which does not support HTTP/2
This PR introduces the use of the HTTPX module, although the HTTP/2 support is still under development in this module seems to work well.
I think that the HTTPX module is the most up-to-date HTTP/2 module of this moment.
The HTTPX package is not provided with Kodi and is unlikely to be included for our request, because this add-on has not been approved for Kodi repository, it could be added if other approved add-ons will use this module,
in the meantime, you will need to include it as internal package including all dependencies and subdependencies.
This PR provides a first solution to this future problem and i think that this PR will not be included in the master branch until the current HTTP1.1 protocol will cause other problems with the endpoints or the website discontinue the support.
TODO List:
To check if all dependencies and sub-dependencies of each module are in placeCheck cookies codeCheck TCP keep-alive communicationsTo implement close session on addon closingAlthough HTTPX imitates Requests with similar properties/arguments a quick recheck of each method is neededTest all endpoints (currently tested: login, main menu and playback)Test standard login on various systems to ensure no regressions (to check if "Incorrect password" error will be fixed or worsened)httpx.RemoteProtocolError: <ConnectionTerminated error_code:ErrorCodes.COMPRESSION_ERROR, last_stream_id:2147483647, additional_data:485041434b202d20696c6c6567616c20696e6465>happen only sometimes and after playing multiple videos, ATM cause not know, could be also an httpx bug (https://paste.kodi.tv/iyubevuxey) (UPD 23/06/2021 after updated all sub-deps seem there is no more errors at least on Windows)
From my tests this PR seem to fully fix the user+password login issues,
i have tried test logging several times on Windows, Linux Mint, CoreELEC with the result of 100% login success,
hoping it is not a coincidence it would be helpful if someone report login test feedbacks