Replaced HTTPX to Requests module #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our local old httpx version have problems with new pyhton versions e.g. 3.11 update the httpx to last version (0.25) cause folowing errors httpcore.RemoteProtocolError: Server disconnected at least while testing on android, that make almost unusuable the addon so for now has been reverted to Requests module. With this will be lost http2 compatibility but since the login is broken, should be not a problem. NOTE: KeepAlive fix has been not reintroduced intentionally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if this PR fulfills these requirements:
Types of changes
Description
Our local old httpx version have problems with new pyhton versions e.g. 3.11
by raising error
AttributeError: module 'httpcore' has no attribute 'NetworkBackend'and updating httpx to last version (0.25) cause folowing errors
httpcore.RemoteProtocolError: Server disconnectedat least while testing on android (#1621), that make almost unusuable the addon,
so for now has been restored Requests module
With this will be lost http2 compatibility but since the login is broken, should be not a problem.
NOTE: KeepAlive fix has been not reintroduced intentionally (ref #1065).
fix #1611
In case of Feature change / Breaking change:
Describe the current behavior
Describe the new behavior
Screenshots (if appropriate):