Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Romanian strings #579

Merged
merged 5 commits into from Apr 20, 2020
Merged

Add Romanian strings #579

merged 5 commits into from Apr 20, 2020

Conversation

tmihai20
Copy link
Contributor

@tmihai20 tmihai20 commented Apr 16, 2020 •
edited

Check if this PR fulfills these requirements:

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Feature change (non-breaking change which change behaviour of an existing functionality)
  • Improvement (non-breaking change which improve functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

In case of Feature change / Breaking change:

Describe the current behavior

Describe the new behavior

Screenshots (if appropriate):

@tmihai20
Add empty file for Romanian translation
1b263e9 
Added empty file for further Romanian translation
@tmihai20
Add Romanian strings
995ee41 
Added Romanian strings
@tmihai20 tmihai20 mentioned this pull request Apr 16, 2020
Open
CastagnaIT
CastagnaIT requested changes Apr 16, 2020
View reviewed changes
Copy link
Owner

@CastagnaIT CastagnaIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission,
need only some imprevements
last thing, is missing also the last id 30240

resources/language/resource.language.ro_ro/strings.po Outdated Show resolved Hide resolved
resources/language/resource.language.ro_ro/strings.po Outdated Show resolved Hide resolved
resources/language/resource.language.ro_ro/strings.po Outdated Show resolved Hide resolved
resources/language/resource.language.ro_ro/strings.po Outdated Show resolved Hide resolved
resources/language/resource.language.ro_ro/strings.po Outdated Show resolved Hide resolved
resources/language/resource.language.ro_ro/strings.po Outdated Show resolved Hide resolved
resources/language/resource.language.ro_ro/strings.po Outdated Show resolved Hide resolved
resources/language/resource.language.ro_ro/strings.po Outdated Show resolved Hide resolved
resources/language/resource.language.ro_ro/strings.po Outdated Show resolved Hide resolved
resources/language/resource.language.ro_ro/strings.po Outdated Show resolved Hide resolved
@tmihai20
Update translation and English strings
ac9e832 
Fixed some Romanian strings and some English strings (with updated Romanian strings).
@tmihai20
Copy link
Contributor Author

I made a new commit fixing what you noticed and I also updated some translated strings.

@tmihai20
Fix review findings
094d0cd 
Fixed some review finding (updated the review date to today).
@CastagnaIT CastagnaIT merged commit acef892 into CastagnaIT:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CastagnaIT CastagnaIT CastagnaIT requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tmihai20 @CastagnaIT