Fix pushing an URL to parseURI (AdReport Broken) #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
tomasko126
changed the title
parseURI
tomasko126
added
bug
itskdog
changed the title
itskdog
reviewed
Jan 20, 2017
| } else { | ||
| if (extracted_domains.indexOf(new parseURI(key).hostname) === -1) { | ||
| extracted_domains.push(new parseURI(key).hostname); | ||
| } |
There was a problem hiding this comment.
Why is the else clause no longer needed?
There was a problem hiding this comment.
@kpeckett Because we can't push key to parseURI anymore, since key looks like: 1:|:https://example.com:|:document and that's not a valid URI -> in this case parseURI would throw an exception.
itskdog
approved these changes
Feb 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126
@kpeckett Another high-brio bug, could you please take a look at it?
Thanks! :)