-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test PR for #999 (a36b8b49aeddf682564a90743e709c875fb7fed6) #1000
Test PR for #999 (a36b8b49aeddf682564a90743e709c875fb7fed6) #1000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint doesn't pass. Please fix all ESLint issues.
/* eslint-enable prefer-object-spread */ | ||
/*eslint prefer-object-spread: "error"*/ | ||
function incorrect() { | ||
Object.assign({}, foo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use an object spread instead of Object.assign
eg: { ...foo }
. prefer-object-spread
Fix available:
Object.assign({}, foo) | |
({ ...foo}) |
function incorrect() { | ||
Object.assign({}, foo) | ||
|
||
Object.assign({}, {foo: 'bar'}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use an object spread instead of Object.assign
eg: { ...foo }
. prefer-object-spread
Fix available:
Object.assign({}, {foo: 'bar'}) | |
({ foo: 'bar'}) |
|
||
Object.assign({}, {foo: 'bar'}) | ||
|
||
Object.assign({ foo: 'bar'}, baz) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use an object spread instead of Object.assign
eg: { ...foo }
. prefer-object-spread
Fix available:
Object.assign({ foo: 'bar'}, baz) | |
({foo: 'bar', ...baz}) |
|
||
Object.assign({ foo: 'bar'}, baz) | ||
|
||
Object.assign({ foo: 'bar' }, Object.assign({ bar: 'foo' })) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use an object spread instead of Object.assign
eg: { ...foo }
. prefer-object-spread
Fix available:
Object.assign({ foo: 'bar' }, Object.assign({ bar: 'foo' })) | |
({foo: 'bar', ...Object.assign({ bar: 'foo' })}) |
|
||
Object.assign({ foo: 'bar'}, baz) | ||
|
||
Object.assign({ foo: 'bar' }, Object.assign({ bar: 'foo' })) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use an object literal instead of Object.assign
. eg: { foo: bar }
. prefer-object-spread
Fix available:
Object.assign({ foo: 'bar' }, Object.assign({ bar: 'foo' })) | |
Object.assign({ foo: 'bar' }, {bar: 'foo'}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint doesn't pass. Please fix all ESLint issues.
/* eslint-enable use-isnan */ | ||
/*eslint use-isnan: ["error", {"enforceForIndexOf": true}]*/ | ||
function incorrect() { | ||
var hasNaN = myArray.indexOf(NaN) >= 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Array prototype method 'indexOf' cannot find NaN. use-isnan
function incorrect() { | ||
var hasNaN = myArray.indexOf(NaN) >= 0; | ||
|
||
var firstIndex = myArray.indexOf(NaN); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Array prototype method 'indexOf' cannot find NaN. use-isnan
|
||
var firstIndex = myArray.indexOf(NaN); | ||
|
||
var lastIndex = myArray.lastIndexOf(NaN); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Array prototype method 'lastIndexOf' cannot find NaN. use-isnan
Finished testing a36b8b4 by 493-1. Closing PR. |
Generated from #999. Run 493. Attempt 1.