-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push Test PR for #1001 (ee3fc81ea506e9d0dc17e881533dac70a8e70611) #1002
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint doesn't pass. Please fix all ESLint issues.
/* eslint prefer-destructuring: ["error"] */ | ||
function incorrect() { | ||
// With `array` enabled | ||
var foo = array[0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use array destructuring. prefer-destructuring
var foo = array[0]; | ||
|
||
// With `object` enabled | ||
var foo = object.foo; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use object destructuring. prefer-destructuring
Fix available:
var foo = object.foo; | |
var {foo} = object; |
|
||
// With `object` enabled | ||
var foo = object.foo; | ||
var foo = object['foo']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use object destructuring. prefer-destructuring
/* eslint-enable no-console */ | ||
/* eslint no-console: "error" */ | ||
function incorrect() { | ||
console.log("Log a debug level message."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected console statement. no-console
Suggestion(s) available:
console.log("Log a debug level message."); | |
/* eslint no-console: "error" */ | ||
function incorrect() { | ||
console.log("Log a debug level message."); | ||
console.warn("Log a warn level message."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected console statement. no-console
Suggestion(s) available:
console.warn("Log a warn level message."); | |
function incorrect() { | ||
console.log("Log a debug level message."); | ||
console.warn("Log a warn level message."); | ||
console.error("Log an error level message."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected console statement. no-console
Suggestion(s) available:
console.error("Log an error level message."); | |
console.log("Log a debug level message."); | ||
console.warn("Log a warn level message."); | ||
console.error("Log an error level message."); | ||
console.log = foo(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected console statement. no-console
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint doesn't pass. Please fix all ESLint issues.
Finished testing ee3fc81 by 497-1. Closing PR. |
Generated from #1001.
Run ID: 9092046362. Number: 497. Attempt: 1.