Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PR for #992 (6b0bd2853594e3765df4a7f1cfb2bb14569d3483) #993

Conversation

CatChen
Copy link
Owner

@CatChen CatChen commented May 14, 2024

Generated from #992. Run 481. Attempt 1.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

/*eslint quote-props: ["error", "as-needed"]*/
function incorrect() {
var object = {
"a": 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessarily quoted property 'a' found. quote-props

Fix available:

Suggested change
"a": 0,
a: 0,

function incorrect() {
var object = {
"a": 0,
"0": 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessarily quoted property '0' found. quote-props

Fix available:

Suggested change
"0": 0,
0: 0,

var object = {
"a": 0,
"0": 0,
"true": 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessarily quoted property 'true' found. quote-props

Fix available:

Suggested change
"true": 0,
true: 0,

"a": 0,
"0": 0,
"true": 0,
"null": 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessarily quoted property 'null' found. quote-props

Fix available:

Suggested change
"null": 0
null: 0

/* eslint-enable no-unsafe-negation */
/*eslint no-unsafe-negation: "error"*/
function incorrect() {
if (!(foo) in object) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected negating the left operand of 'in' operator. no-unsafe-negation

Suggestion(s) available:

Suggested change
if (!(foo) in object) {
if (!((foo) in object)) {
Suggested change
if (!(foo) in object) {
if ((!(foo)) in object) {

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

Copy link
Contributor

Finished testing 6b0bd28 by 481-1. Closing PR.

@github-actions github-actions bot closed this May 14, 2024
@github-actions github-actions bot deleted the workflows/tests/481-1-on-6b0bd2853594e3765df4a7f1cfb2bb14569d3483 branch May 14, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant