-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test PR for #997 (a74dedb27994832bbbde2a31bbb2f387afaac34c) #998
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint doesn't pass. Please fix all ESLint issues.
/* eslint-enable prefer-regex-literals */ | ||
/*eslint prefer-regex-literals: ["error", {"disallowRedundantWrapping": true}]*/ | ||
function incorrect() { | ||
new RegExp(/abc/); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regular expression literal is unnecessarily wrapped within a 'RegExp' constructor. prefer-regex-literals
Suggestion(s) available:
new RegExp(/abc/); | |
/abc/; |
function incorrect() { | ||
new RegExp(/abc/); | ||
|
||
new RegExp(/abc/, 'u'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use regular expression literal with flags instead of the 'RegExp' constructor. prefer-regex-literals
Suggestion(s) available:
new RegExp(/abc/, 'u'); | |
/abc/u; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint doesn't pass. Please fix all ESLint issues.
Finished testing a74dedb by 489-1. Closing PR. |
Generated from #997. Run 489. Attempt 1.