Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PR for #997 (a74dedb27994832bbbde2a31bbb2f387afaac34c) #998

Conversation

CatChen
Copy link
Owner

@CatChen CatChen commented May 15, 2024

Generated from #997. Run 489. Attempt 1.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

/* eslint-enable prefer-regex-literals */
/*eslint prefer-regex-literals: ["error", {"disallowRedundantWrapping": true}]*/
function incorrect() {
new RegExp(/abc/);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regular expression literal is unnecessarily wrapped within a 'RegExp' constructor. prefer-regex-literals

Suggestion(s) available:

Suggested change
new RegExp(/abc/);
/abc/;

function incorrect() {
new RegExp(/abc/);

new RegExp(/abc/, 'u');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use regular expression literal with flags instead of the 'RegExp' constructor. prefer-regex-literals

Suggestion(s) available:

Suggested change
new RegExp(/abc/, 'u');
/abc/u;

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

Copy link
Contributor

Finished testing a74dedb by 489-1. Closing PR.

@github-actions github-actions bot closed this May 15, 2024
@github-actions github-actions bot deleted the workflows/tests/489-1-on-a74dedb27994832bbbde2a31bbb2f387afaac34c branch May 15, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant