Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update algorithms container interface #34

merged 4 commits into from Aug 13, 2018

Update algorithms container interface #34

merged 4 commits into from Aug 13, 2018


Copy link

@c-w c-w commented Aug 11, 2018

  • Enable multiple repeated files in interface
  • Add PREALIGNED flag to face algorithm container
@c-w c-w requested a review from michaelperel Aug 11, 2018

def find_faces(img: Image) -> Iterable[Image]:
for top, right, bottom, left in face_locations(img):
yield img[top:bottom, left:right]
Copy link

@armanrahman22 armanrahman22 Aug 12, 2018

Should we try replacing the face_recognition face finding with MTCNN for consistency across algorithms? We can use this pip installable package (

Copy link
Contributor Author

@c-w c-w Aug 12, 2018

I'd rather keep this one simple for consistency with the ICRC v1 deployment so that we have a true baseline for comparison.

@c-w c-w merged commit 650edb9 into master Aug 13, 2018
2 checks passed
@c-w c-w deleted the prealign-flag branch Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants