This repository has been archived by the owner on Mar 7, 2018. It is now read-only.
Update translator auth to just use account key #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has the advantage that the key is very easy to pass-through from the Azure ARM deployment when we set up the translation Cognitive Service. Also, the documentation mentions the /sts/v1.0/issueToken as the standard way to authenticate with the translation service going forward, so this will be more future proof, see: http://docs.microsofttranslator.com/text-translate.html#Authorization
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has the advantage that the key is very easy to pass-through from the Azure ARM deployment when we set up the translation Cognitive Service.
Also, the documentation mentions the /sts/v1.0/issueToken as the standard way to authenticate with the translation service going forward, so this will be more future proof, see the docs.
Proof that the new auth works: