Skip to content
This repository has been archived by the owner. It is now read-only.

Update translator auth to just use account key #74

Merged
merged 2 commits into from Jul 11, 2017

Conversation

Projects
None yet
3 participants
@c-w
Copy link
Member

commented Jul 7, 2017

This has the advantage that the key is very easy to pass-through from the Azure ARM deployment when we set up the translation Cognitive Service.

Also, the documentation mentions the /sts/v1.0/issueToken as the standard way to authenticate with the translation service going forward, so this will be more future proof, see the docs.

Proof that the new auth works:

image

c-w added some commits Jul 7, 2017

Update translator auth to just use account key
This has the advantage that the key is very easy to pass-through from
the Azure ARM deployment when we set up the translation Cognitive
Service.

Also, the documentation mentions the /sts/v1.0/issueToken as the
standard way to authenticate with the translation service going forward,
so this will be more future proof, see:
http://docs.microsofttranslator.com/text-translate.html#Authorization
@jcjimenez
Copy link
Contributor

left a comment

LGTM

@c-w c-w merged commit 5c6c4f4 into master Jul 11, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@c-w c-w deleted the translator-auth-update branch Jul 11, 2017

@c-w c-w removed the in progress label Jul 11, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.