Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catel.Fody doesn't weave the virtual properties correctly #291

Closed
1 task done
ghost opened this issue Dec 11, 2020 · 4 comments
Closed
1 task done

Catel.Fody doesn't weave the virtual properties correctly #291

ghost opened this issue Dec 11, 2020 · 4 comments
Assignees
@GeertvanHorrik
Milestone
4.6.0

Comments

@ghost
Copy link

ghost commented Dec 11, 2020 •
edited by ghost

Catel.Fody.Repro.zip

  • .NET Core

Component

Catel.Fody weaving properties

Version of Library

4.5.0

Version of OS(s) listed above with issue

win 10

Steps to Reproduce

use the attached repro.

Expected Behavior

properties declared as virtual should also be included in OnPropertyChanged if they have been used in a calculation property.

Actual Behavior

only not virtual properties will be included in OnPropertyChanged
@GeertvanHorrik GeertvanHorrik self-assigned this Dec 11, 2020
@GeertvanHorrik
Copy link
Member

Thanks for reporting. We will investigate once we have resources available.

@GeertvanHorrik GeertvanHorrik added this to the 4.6.0 milestone Jan 5, 2021
@GeertvanHorrik
Copy link
Member

Trying to write unit tests around this repro.

@GeertvanHorrik
Copy link
Member

can repro with unit test.

GeertvanHorrik added a commit that referenced this issue Jan 7, 2021
@GeertvanHorrik
#291 Catel.Fody doesn't weave the virtual properties correctly
ac799d0
@GeertvanHorrik
Copy link
Member

Fixed.

@xaevik xaevik mentioned this issue Jan 8, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GeertvanHorrik GeertvanHorrik

Labels
None yet
Projects
None yet
Milestone
4.6.0
Development

No branches or pull requests
1 participant
@GeertvanHorrik