#983 Remove INotifyPropertyChanging and only support INotifyPropertyC…

…hanged
Catel · Jun 13, 2017 · e19c206 · e19c206
1 parent f569c16
commit e19c206
Show file tree

Hide file tree

Showing 41 changed files with 43 additions and 846 deletions.
diff --git a/doc/catel rules.txt b/doc/catel rules.txt
@@ -3,10 +3,9 @@ Defines
 
 All debug versions have DEBUG
 
-NET35		NET, NET35
-NET40		NET, NET40
 NET45		NET, NET45
 NET46		NET, NET46
+NET47		NET, NET47
 PCL			PCL
 
 Note that defines must be set for Debug and Release configurations

diff --git a/doc/history.txt b/doc/history.txt
@@ -106,6 +106,7 @@ Added/fixed:
 (-) #131     Remove ISplashScreenService
 (-) #916     Remove IXmlSerializer.OptimalizationMode in favor of ISerializationConfiguration.OptimalizationMode
 (-) #974     Remove DynamicEventListener in favor of WeakEventListener
+(-) #983     Remove INotifyPropertyChanging and only support INotifyPropertyChanged 
 (-) #1010    Remove PleaseWaitHelper and use busy indicator instead 
 (-) #1016    Remove CountCollapsedConverter since we already have CollectionToVisibilityConverter
 (-) #1030    Remove CommandLineHelper in favor of Orc.CommandLine

diff --git a/src/Catel.Core/Catel.Core.Shared/Catel.Core.Shared.projitems b/src/Catel.Core/Catel.Core.Shared/Catel.Core.Shared.projitems
@@ -50,19 +50,13 @@
     <Compile Include="$(MSBuildThisFileDirectory)ComponentModel\EventArgs\BeginEditEventArgs.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ComponentModel\EventArgs\CancelEditCompletedEventArgs.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ComponentModel\EventArgs\CancelEditEventArgs.cs" />
-    <Compile Include="$(MSBuildThisFileDirectory)ComponentModel\EventArgs\DataErrorsChangedEventArgs.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ComponentModel\EventArgs\EditEventArgs.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ComponentModel\EventArgs\EndEditEventArgs.cs" />
-    <Compile Include="$(MSBuildThisFileDirectory)ComponentModel\EventArgs\PropertyChangingEventArgs.cs" />
-    <Compile Include="$(MSBuildThisFileDirectory)ComponentModel\EventArgs\RunWorkerCompletedEventArgs.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ComponentModel\Extensions\PropertyChangedEventArgsExtensions.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ComponentModel\IAdvancedEditableObject.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ComponentModel\IDataErrorInfo.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ComponentModel\IDataWarningInfo.cs" />
-    <Compile Include="$(MSBuildThisFileDirectory)ComponentModel\INotifyDataErrorInfo.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ComponentModel\INotifyDataWarningInfo.cs" />
-    <Compile Include="$(MSBuildThisFileDirectory)ComponentModel\INotifyPropertyChanging.cs" />
-    <Compile Include="$(MSBuildThisFileDirectory)ComponentModel\RunWorkerCompletedEventHandler.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Configuration\ConfigurationContainer.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Configuration\ConfigurationService.net.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Configuration\ConfigurationService.cs" />
@@ -86,7 +80,6 @@
     <Compile Include="$(MSBuildThisFileDirectory)Data\Validation\CompositeValidator.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Data\Validation\CompositeValidatorProvider.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Data\EventArgs\AdvancedPropertyChangedEventArgs.cs" />
-    <Compile Include="$(MSBuildThisFileDirectory)Data\EventArgs\AdvancedPropertyChangingEventArgs.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Data\EventArgs\ValidationEventArgs.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Data\Exceptions\InvalidPropertyException.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Data\Exceptions\InvalidPropertyValueException.cs" />
@@ -104,7 +97,6 @@
     <Compile Include="$(MSBuildThisFileDirectory)Data\Helpers\ValidationContextHelper.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Data\Helpers\XmlNameMapper.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Data\Interfaces\IAdvancedNotifyPropertyChanged.cs" />
-    <Compile Include="$(MSBuildThisFileDirectory)Data\Interfaces\IAdvancedNotifyPropertyChanging.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Data\Interfaces\IModel.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Data\Interfaces\IModelEditor.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Data\Interfaces\IModelEqualityComparer.cs" />

diff --git a/src/Catel.Core/Catel.Core.Shared/ComponentModel/EventArgs/DataErrorsChangedEventArgs.cs b/src/Catel.Core/Catel.Core.Shared/ComponentModel/EventArgs/DataErrorsChangedEventArgs.cs
diff --git a/src/Catel.Core/Catel.Core.Shared/ComponentModel/EventArgs/PropertyChangingEventArgs.cs b/src/Catel.Core/Catel.Core.Shared/ComponentModel/EventArgs/PropertyChangingEventArgs.cs
diff --git a/src/Catel.Core/Catel.Core.Shared/ComponentModel/EventArgs/RunWorkerCompletedEventArgs.cs b/src/Catel.Core/Catel.Core.Shared/ComponentModel/EventArgs/RunWorkerCompletedEventArgs.cs
diff --git a/src/Catel.Core/Catel.Core.Shared/ComponentModel/INotifyDataErrorInfo.cs b/src/Catel.Core/Catel.Core.Shared/ComponentModel/INotifyDataErrorInfo.cs
diff --git a/src/Catel.Core/Catel.Core.Shared/ComponentModel/INotifyPropertyChanging.cs b/src/Catel.Core/Catel.Core.Shared/ComponentModel/INotifyPropertyChanging.cs
diff --git a/src/Catel.Core/Catel.Core.Shared/ComponentModel/RunWorkerCompletedEventHandler.cs b/src/Catel.Core/Catel.Core.Shared/ComponentModel/RunWorkerCompletedEventHandler.cs
diff --git a/src/Catel.Core/Catel.Core.Shared/Data/EventArgs/AdvancedPropertyChangingEventArgs.cs b/src/Catel.Core/Catel.Core.Shared/Data/EventArgs/AdvancedPropertyChangingEventArgs.cs
diff --git a/src/Catel.Core/Catel.Core.Shared/Data/Interfaces/IAdvancedNotifyPropertyChanging.cs b/src/Catel.Core/Catel.Core.Shared/Data/Interfaces/IAdvancedNotifyPropertyChanging.cs
diff --git a/src/Catel.Core/Catel.Core.Shared/Data/Interfaces/IModel.cs b/src/Catel.Core/Catel.Core.Shared/Data/Interfaces/IModel.cs
@@ -15,7 +15,7 @@ namespace Catel.Data
     /// <remarks>
     /// This interface defines all the non-generic interfaces that the <see cref="ModelBase"/> class implements.
     /// </remarks>
-    public interface IModel : INotifyPropertyChanging, INotifyPropertyChanged, IParent, IAdvancedEditableObject, 
+    public interface IModel : INotifyPropertyChanged, IParent, IAdvancedEditableObject, 
         IModelEditor, IModelValidation, IModelSerialization
     {
         #region Properties

diff --git a/src/Catel.Core/Catel.Core.Shared/Data/ModelBase.propertyediting.cs b/src/Catel.Core/Catel.Core.Shared/Data/ModelBase.propertyediting.cs
@@ -110,21 +110,6 @@ internal void SetValue(PropertyData property, object value, bool notifyOnChange,
                 oldValue = GetValueFast<object>(property.Name);
                 var areOldAndNewValuesEqual = ObjectHelper.AreEqualReferences(oldValue, value);
 
-                if (notifyOnChange && (AlwaysInvokeNotifyChanged || !areOldAndNewValuesEqual) && !LeanAndMeanModel)
-                {
-                    if (changeNotificationsSuspensionContext == null)
-                    {
-                        var propertyChangingEventArgs = new AdvancedPropertyChangingEventArgs(property.Name);
-                        RaisePropertyChanging(this, propertyChangingEventArgs);
-
-                        if (propertyChangingEventArgs.Cancel)
-                        {
-                            Log.Debug("Change of property '{0}.{1}' is canceled in PropertyChanging event", GetType().FullName, property.Name);
-                            return;
-                        }
-                    }
-                }
-
                 // Validate before assigning, dynamic properties will cause exception
                 if (validateAttributes && !LeanAndMeanModel)
                 {