Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire device/folder approval notifications on app start (fixes #467) #471

Merged
merged 52 commits into from
Nov 10, 2019

Conversation

Catfriend1
Copy link
Owner

@Catfriend1 Catfriend1 commented Aug 18, 2019

Purpose:

Caused by change in upstream:
syncthing/PR 5084 - syncthing/syncthing#5084

Testing with AVD 9.x at commit #0114cae - verified working.

@Catfriend1 Catfriend1 added the bug label Aug 18, 2019
@Catfriend1 Catfriend1 self-assigned this Aug 18, 2019
@Catfriend1
Copy link
Owner Author

 I/SyncthingNativeCode: [YLW7H] INFO: Connection from 7LTUV3P-Y37HQXK-UUM7S5Q-2NDQT3B-SA4WAT4-T5ODX3V-XRXAF7Z-MXM7GAA at 89.221.214.63:22067 (relay-server) rejected: unknown device
2019-08-31 15:20:37.752 10057-10120/ D/Volley: [461] BasicNetwork.logSlowRequests: HTTP response for request=<[ ] https://127.0.0.1:8384/rest/events?since=19&limit=0 0x59c3b57d NORMAL 612> [lifetime=38090], [size=8603], [rc=200], [retryCount=3]
2019-08-31 15:20:37.760 10057-10057/ V/EventProcessor: Forwarding ConfigSaved event to RestApi to get the updated config.
2019-08-31 15:20:37.760 10057-10057/ V/ApiRequest: Performing request to https://127.0.0.1:8384/rest/system/config
2019-08-31 15:20:37.760 10057-10057/ D/EventProcessor: Unknown device 'TEST' (7LTUV3P-Y37HQXK-UUM7S5Q-2NDQT3B-SA4WAT4-T5ODX3V-XRXAF7Z-MXM7GAA) wants to connect
2019-08-31 15:20:37.783 10057-10057/ D/RestApi: onReloadConfigComplete: Successfully parsed configuration.
2019-08-31 15:20:37.783 10057-10057/ V/RestApi: mConfig.pendingDevices = [{"address":"89.221.214.63:22067","deviceID":"7LTUV3P-Y37HQXK-UUM7S5Q-2NDQT3B-SA4WAT4-T5ODX3V-XRXAF7Z-MXM7GAA","name":"TEST","time":"2019-08-31T13:20:38Z"}]
2019-08-31 15:20:37.783 10057-10057/ V/RestApi: mConfig.remoteIgnoredDevices = []
2019-08-31 15:20:37.783 10057-10057/ V/RestApi: pendingDevice.deviceID = 7LTUV3P-Y37HQXK-UUM7S5Q-2NDQT3B-SA4WAT4-T5ODX3V-XRXAF7Z-MXM7GAA('TEST')

@Catfriend1 Catfriend1 changed the title Fire device/folder approval notifications after app start (fixes #467) Fire device/folder approval notifications on app start (fixes #467) Aug 31, 2019
@Catfriend1 Catfriend1 added enhancement and removed bug labels Sep 1, 2019
@Catfriend1
Copy link
Owner Author

Under the device offering a folder:
<pendingFolder time="2019-11-10T15:32:41+01:00" id="9MeeC-6yyAY" label="lp_test"></pendingFolder>

@Catfriend1
Copy link
Owner Author

Ignoring the folder gives below the offering device node:
<ignoredFolder time="2019-11-10T14:33:46.777Z" id="9MeeC-6yyAY" label="lp_test"></ignoredFolder>

@Catfriend1 Catfriend1 added this to the 1.3.1 milestone Nov 10, 2019
@Catfriend1
Copy link
Owner Author

@ Review / Complete.
lgtm.

@Catfriend1 Catfriend1 merged commit 25e1893 into master Nov 10, 2019
@Catfriend1 Catfriend1 deleted the 20190818-fixIssue467 branch November 10, 2019 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make use of persistent devicePending and folderPending config nodes
1 participant