Time schedule: sync if conditions are fulfilled and last sync was more than 1h ago (fixes #592) #766

Helium314 · 2021-03-21T19:04:17Z

With this PR, syncthing running on schedule will start immediately once all other run conditions are fulfilled and last sync was more than 1h ago.

Currently it is working as intended on my device.

when running on schedule, this allow syncthing to run if it was last running more than WAIT_FOR_NEXT_SYNC_DELAY_SEC ago instead of keeping a strict schedule

Catfriend1 · 2021-03-21T20:31:35Z

wow, cool 👍 . Many thanks! I think we will have a merging session together if I'm back at my pc.

Catfriend1 · 2021-03-21T20:35:12Z

I think we should store mLastRunTime as a PREF_ so the app considers it when closed and relaunched. I can help with that.

Helium314 · 2021-03-22T07:19:00Z

Assume: run on schedule, run on WiFI:

a)

start app when on WiFi

b)

start app when not on WiFi
wait 3 min
enable WiFi

c)

start app when not on WiFi
wait 6 min
enable WiFi

Current behavior:
a) syncthing runs for 5 min
b) syncthing runs for 2 min
c) syncthing does not run

With this PR:
a) syncthing runs for 5 min
b) syncthing runs for 2 min
c) syncthing runs for 5 min

When storing mLastRunTime in settings (not tested):
a) syncthing runs for 5 min
b) syncthing runs for 2 min
c) syncthing runs for 5 min, but only if the last run was more than 1 h ago

I think for consistency the initial state of mTimeConditionMatch should depend on mLastRunTime, something like
private Boolean mTimeConditionMatch = SystemClock.elapsedRealtime() - mPreferences.getLong(Constants.PREF_LAST_RUN_TIME,0) > Constants.WAIT_FOR_NEXT_SYNC_DELAY_SEC * 1000;
(and moved below SharedPreferences mPreferences;)

Then I would expect:
a) and b) and c) syncthing runs for 5 min, but only if the last run was more than 1 h ago

But if syncthing does not run at a), scheduleSyncTriggerServiceJob will trigger the next sync 1 h after app start, and not 1 h after last run. So initially the values for scheduleSyncTriggerServiceJob should be

        JobUtils.scheduleSyncTriggerServiceJob(context,
                mTimeConditionMatch ?
                    Constants.TRIGGERED_SYNC_DURATION_SECS :
                    Constants.WAIT_FOR_NEXT_SYNC_DELAY_SECS - (SystemClock.elapsedRealtime() - mPreferences.getLong(Constants.PREF_LAST_RUN_TIME,0))/1000
        );

Negative values should not matter, in this case mTimeConditionMatch is true anyway.

And: when storing the time System.currentTimeMillis() is probably better; SystemClock.elapsedRealtime() is time (ms) since last boot, so a reboot will mess up the schedule.
But when using System.currentTimeMillis() there are other obscure scenarios where schedule could be messed up... I can imagine something like:
I drop my phone the battery falls out and system time is re-set to some old value. Now syncthing will not run until the phone has the correct time again.
But system time is usually updated automatically anayway as soon as there is internet connection. Still, some saftety against this would be good. Maybe simply setting initial mTimeConditionMatch to true if Constants.PREF_LAST_RUN_TIME > SystemClock.elapsedRealtime() is sufficient.

Helium314 · 2021-03-22T08:08:18Z

private Boolean mTimeConditionMatch = SystemClock.elapsedRealtime() - mPreferences.getLong(Constants.PREF_LAST_RUN_TIME,0) > Constants.WAIT_FOR_NEXT_SYNC_DELAY_SEC * 1000;

or better:
private Boolean mTimeConditionMatch = SystemClock.elapsedRealtime() - mPreferences.getLong(Constants.PREF_LAST_RUN_TIME,0) > 0;

So mTimeConditionMatch is initially true only if run after reboot (or time problem in case of System.currentTimeMillis(), which is the better one to use here).
Before reaching scheduleSyncTriggerServiceJob it should be set to true anyway in updateShouldRunDecision() if conditions allow.

Catfriend1 · 2021-03-22T12:40:30Z

Looks good to me what you suggest, but currently, I've got no time, sorry. Will come back later here, compile and test it on the emulator to get an impression.

Helium314 · 2021-03-22T18:21:46Z

Will come back later here, compile and test it on the emulator to get an impression.

No problem, this just means longer testing on my side.

Meanwhile I've adjusted the version running on my phone to use PREF_LAST_RUN_TIME.
Code didn't work exactly as I had imagined above, but now it seems good... will update the PR if there are no further problems.

But I'll keep using SystemClock.elapsedRealtime(), because I noticed System.currentTimeMillis() changes with time zone and summer time, so UTC offset always needs to be considered. And if the user decides to manually play around with the time it gets even worse...

Catfriend1 · 2021-03-22T20:01:18Z

I'm fine with your decision :-). Every improvement over how it was before is good.

Catfriend1 · 2021-03-27T06:26:12Z

app/src/main/java/com/nutomic/syncthingandroid/service/RunConditionMonitor.java

-
-    private long mLastRunTime = 0;
+    private Boolean mTimeConditionMatch = false;
+    private Boolean stopJobScheduled = false;


Let's take mStopJobScheduled , optionally does the positive way ease understanding of the code (mStartJobScheduled)?

I really don't know what name would be best for understanding...

Basically I needed some variable to store whether we are in run-for-5-min phase, where the next intent with ACTION_SYNC_TRIGGER_FIRED stops this phase (this intent is scheduled when entering the phase)

mStopJobScheduled is not nice, intially I had named it something like runningAllowed, but that's not better...

ok, something with "m" in front is best. choose what you like or we take mRunAllowedStopScheduled

Not too long, and clear enough. Thanks!

Catfriend1 · 2021-03-27T06:28:50Z

app/src/main/java/com/nutomic/syncthingandroid/service/Constants.java

@@ -29,7 +29,8 @@
    public static final String PREF_RESPECT_MASTER_SYNC         = "respect_master_sync";
    public static final String PREF_RUN_IN_FLIGHT_MODE          = "run_in_flight_mode";
    public static final String PREF_RUN_ON_TIME_SCHEDULE        = "run_on_time_schedule";
-
+    public static final String PREF_LAST_RUN_TIME               = "last_run_time";


-> down to line 88 because it's a cached pref the user does not see nor can edit?

yes, that would definitely be the right place

Catfriend1 · 2021-03-28T07:53:19Z

Thanks, do you consider this production ready now? Should we change some UI strings or put explanation somewhere (in app, wiki) to tell users the changed feature behavior?

Helium314 · 2021-03-28T08:50:50Z

Yes, I think the code is ok now.

https://github.com/Catfriend1/syncthing-android/blob/main/app/src/main/res/values/strings.xml#L532
might be ok (actually the behaviour intruduced with this PR is what I had initially expected when reading the description)
It could be more accurate, but it's really long already.
What do you think of changing
Enabling this option will attempt to sync every hour for the duration of 5 minutes
to Enabling this option will attempt to sync for the duration of 5 minutes if the last sync was more than 1 hour ago
or Enabling this option will attempt to sync for the duration of 5 minutes if run conditions are fulfilled and the last sync was more than 1 hour ago

Catfriend1 · 2021-03-28T09:16:01Z

Enabling this option will attempt to sync for the duration of 5 minutes if run conditions are fulfilled and the last sync was more than 1 hour ago

Good! we only need to adjust the values/strings.xml (no translations, only the english one). Transifex will later do the rest.

Catfriend1 · 2021-03-28T11:43:21Z

Merged into "beta" branch.

…e than 1h ago (#766)

Catfriend1 · 2021-03-28T12:13:21Z

@Helium314 Would you mind to also show when the last sync was as that would be more useful for our users?

How did you test it? I'm currently failing to test because of SystemElapsedTime (which is not a bad idea but I cannot change via date/time control to jump an hour to the future).

Helium314 · 2021-03-28T15:25:44Z

How did you test it?

The simple and blunt way: switching off WiFi before first hour ends, switching back on a bit later and checking how long ST stays running.
Admittedly not ideal if you don't want to test quickly... I thought about using/adding some log entries, which wouldn't be faster but require less attention.

Would you mind to also show when the last sync was as that would be more useful for our users?

Currently testing with something like String.format("last sync was %d minutes ago", msSinceLastSync/60000), probably needs a bit of polishing:

0 minutes (anything less than 60 seconds) looks awkward, maybe 'less than 1 minute' would be better
it says '...was 1 minutes ago'. Is there any simple way of fixing this? Or should I add another string for one minute?
If I use the (adjusted) string from strings.xml, Android Studio complains about it not being a valid format string. I guess this is because the translations don't contain '%d'?

Catfriend1 · 2021-04-02T10:33:11Z

btw: I've fixed the Android 11 emulator detection so it's easier for you to test the sync scheduling. See 35cbb17 (intervals are lower on the emulator)

Catfriend1 · 2021-04-02T11:33:12Z

@Helium314 Would you mind adding more comments between the lines on how the new timing mechanisms work in PR #766 and PR #768 ?

Catfriend1 · 2021-04-02T11:46:33Z

PASSED. Log when running without "run according to time schedule checked" -> result: Syncthing stays running all time.

``` 2021-03-28 16:58:08.567 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 10(+120) seconds. 2021-03-28 16:58:18.597 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 16:58:38.630 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 16:59:08.842 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 16:59:39.062 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:00:09.242 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:00:39.413 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:01:09.604 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:01:39.786 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:02:12.105 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:02:44.470 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:03:14.678 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:03:44.880 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:04:15.064 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:04:45.254 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:05:05.285 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:05:25.327 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:05:55.560 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:06:25.749 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:06:55.955 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:07:15.989 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:07:36.022 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:08:06.157 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:08:36.224 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:09:06.344 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:09:36.413 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:10:06.502 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:10:36.625 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:11:06.708 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:11:36.761 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:12:09.104 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:12:39.281 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:13:09.466 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. ```

Catfriend1 · 2021-04-02T11:49:38Z

PASSED. Log when running with "run according to time schedule checked" -> result: works correct. Syncthing flip flops on/off.

2021-03-28 17:14:40.132 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 10(+120) seconds.
2021-03-28 17:14:50.773 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds.
2021-03-28 17:15:10.909 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 10(+120) seconds.
2021-03-28 17:15:21.524 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds.
2021-03-28 17:15:41.677 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 10(+120) seconds.
2021-03-28 17:15:52.267 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds.
2021-03-28 17:16:19.745 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 10(+120) seconds.
2021-03-28 17:16:30.376 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds.

Catfriend1 · 2021-04-02T11:53:05Z

PASSED: Turning wifi (required condition off) -> Log repeats "Scheduled SyncTriggerJobService to run in 20(+120) seconds" ("off" intervals are scheduled over and over again). After the first 20 secs off interval passed by, the run condition monitor shows this signalising it's time for a new sync schedule but wifi is required.

Now enabling WiFi.

Got 10 seconds of ON interval and syncing.

2021-03-28 17:20:30.501 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 10(+120) seconds.

After that, with wifi on, the flip flopping continues as usual.

Log:

2021-03-28 17:17:55.064 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:18:25.311 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:18:55.451 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:19:25.623 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:20:00.471 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:20:30.501 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 10(+120) seconds. 2021-03-28 17:20:41.146 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-03-28 17:21:06.427 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 10(+120) seconds. 2021-03-28 17:21:17.032 13758-13758/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds.

Catfriend1 · 2021-04-02T12:15:03Z

app/src/main/java/com/nutomic/syncthingandroid/service/RunConditionMonitor.java

@@ -104,7 +105,8 @@ public void run() {
     * Holds true if we are within a "SyncthingNative should run" time frame.
     * Initial status true because we like to sync on app start, too.
     */
-    private Boolean mTimeConditionMatch = true;
+    private Boolean mTimeConditionMatch = false;


Why was this switched to intially be "false"? The comment above it needs to be adjusted.

I see you already figured that out... sorry, a short comment might have saved you a lot of time

…on init

Catfriend1 · 2021-04-02T12:26:25Z

There is a problem when the system clock resets (very high positive values to wait for next sync) or the last sync was more than an hour ago (force stop case, negative scheduled values).

Log:

2021-04-02 14:24:40.741 7467-7467/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 11(+120) seconds. 2021-04-02 14:24:46.096 7467-7467/com.github.catfriend1.syncthingandroid.debug D/RunConditionMonitor: JobPrepare: mTimeConditionMatch=false, elapsedRealtime=826916, lastSyncTimeSinceBootMillisecs=812514, elapsedSecondsSinceLastSync=14 2021-04-02 14:24:46.104 7467-7467/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 6(+120) seconds. 2021-04-02 14:24:49.429 7467-7467/com.github.catfriend1.syncthingandroid.debug D/RunConditionMonitor: JobPrepare: mTimeConditionMatch=false, elapsedRealtime=830249, lastSyncTimeSinceBootMillisecs=812514, elapsedSecondsSinceLastSync=17 2021-04-02 14:24:49.440 7467-7467/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 3(+120) seconds. 2021-04-02 14:24:53.271 7467-7467/com.github.catfriend1.syncthingandroid.debug D/RunConditionMonitor: JobPrepare: mTimeConditionMatch=false, elapsedRealtime=834091, lastSyncTimeSinceBootMillisecs=812514, elapsedSecondsSinceLastSync=21 2021-04-02 14:24:53.274 7467-7467/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in -1(+120) seconds. 2021-04-02 14:24:53.718 7467-7467/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds. 2021-04-02 14:24:58.656 7467-7467/com.github.catfriend1.syncthingandroid.debug D/RunConditionMonitor: JobPrepare: mTimeConditionMatch=false, elapsedRealtime=839477, lastSyncTimeSinceBootMillisecs=812514, elapsedSecondsSinceLastSync=26 2021-04-02 14:24:58.659 7467-7467/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in -6(+120) seconds. 2021-04-02 14:24:59.057 7467-7467/com.github.catfriend1.syncthingandroid.debug I/JobUtils: Scheduled SyncTriggerJobService to run in 20(+120) seconds.

…" instead

Catfriend1 · 2021-04-02T12:53:07Z

@Helium314

There is a problem when the system clock resets (very high positive values to wait for next sync) or the last sync was more than an hour ago (force stop case, negative scheduled values).

I didn't see the "updateShouldRunDecision();" already has code to catch the negative values and very positive values. So if I remove my simulation code line "elapsedRealtime = 0;" (l.175) it works correctly. Though, I feel more comfortable with more comments, especially on the "mRunAllowedStopScheduled" mechanism. I am sitting over the code for more than an hour now and fail to understand how it works, even the "run immendiately when share to" is used works correctly during tests.

Catfriend1 · 2021-04-02T13:02:37Z

Anyway, I'm giving this a shot. It worked too well on my tests :-). But in return, I hope you'll assist me in the future if we need to polish the whole SyncTriggerJob thingy together, add more comments on code (would be my wish for you next PR @Helium314 if I'm allowed to make one :-) ). Especially this "systemClock.elapsedTime" thingy could be split in functions to stamp out negative / postive "wrong" values maybe in the init check of RunConditionMonitor before the first code parts might run into calculations and requiring to fix the values up "last-minute". Thanks for the contribution!

Helium314 · 2021-04-02T16:50:56Z

Wow, there was a lot going on while I wasn't watching 😄

sooo... slowly going though your updates:

@Helium314 Would you mind adding more comments between the lines on how the new timing mechanisms work in PR #766 and PR #768 ?

sure, will go through it again and comment

PASSED. Log when running without "run according to time schedule checked" -> result: Syncthing stays running all time.

there seems to be a lot of scheduling going on even when not running on schedule... this doesen't look nice (but on a real device it would only be every hour, so not that bad).
Or was it like this already before this PR?

Catfriend1 · 2021-04-02T18:27:07Z

Or was it like this already before this PR?
Yes, it was. Nicer would be to have a PR in the future that starts the JobSchedulerService only if its required. Requires some more code to instantiate/run and shutdown/stop the class though. Does not harm battery in real life atm.

allow less strict time frame when running on schedule

7b3cb14

when running on schedule, this allow syncthing to run if it was last running more than WAIT_FOR_NEXT_SYNC_DELAY_SEC ago instead of keeping a strict schedule

Catfriend1 self-requested a review March 21, 2021 20:31

Catfriend1 added the enhancement label Mar 21, 2021

Helium314 added 2 commits March 25, 2021 14:36

store last run time in preferences, some fixes

01eec89

add PREF_LAST_RUN_TIME

8e3bf3c

Catfriend1 reviewed Mar 27, 2021

View reviewed changes

Helium314 added 3 commits March 27, 2021 16:22

move PREF_LAST_RUN_TIME to correct category

d008f1f

remove spaces

c8fcb96

rename stopJobScheduled to mRunAllowedStopScheduled

8bc95a1

update string for run_on_time_schedule_summary

a325833

Catfriend1 assigned Helium314 Mar 28, 2021

Catfriend1 linked an issue Mar 28, 2021 that may be closed by this pull request

Time schedule: sync if conditions are fulfilled and last sync was more than 1h ago #592

Closed

Catfriend1 added the testing Community test case - Notice: Consists of maybe unstable syncthing version or code label Mar 28, 2021

Catfriend1 approved these changes Mar 28, 2021

View reviewed changes

Catfriend1 added this to the v1.15.0 milestone Mar 28, 2021

Catfriend1 added a commit that referenced this pull request Mar 28, 2021

Time schedule: sync if conditions are fulfilled and last sync was mor…

db30c0e

…e than 1h ago (#766)

Catfriend1 approved these changes Mar 31, 2021

View reviewed changes

dont mRunAllowedStopScheduled=true if forced to start

8d78f45

Catfriend1 approved these changes Apr 2, 2021

View reviewed changes

Catfriend1 added 3 commits April 2, 2021 13:24

Merge branch 'main' into pr/766

41910fb

add comment

ddbfe75

Update Constants.java

7446378

better self-explanatory code

3215816

Catfriend1 reviewed Apr 2, 2021

View reviewed changes

Catfriend1 added 2 commits April 2, 2021 14:20

fix code formatting, add log, honor mTimeConditionMatch always false …

ae86d51

…on init

more log

352a1f2

Catfriend1 added 2 commits April 2, 2021 14:30

JobUtils: Fix scheduling with a negative time, use fire after "0 secs…

936af14

…" instead

revert

f467017

Catfriend1 added 2 commits April 2, 2021 14:55

fix code formatting

3897fff

Comment, please review if correct @Helium314

94406ec

Catfriend1 merged commit 548efb6 into Catfriend1:main Apr 2, 2021

Catfriend1 removed the testing Community test case - Notice: Consists of maybe unstable syncthing version or code label Apr 2, 2021

Catfriend1 mentioned this pull request Apr 4, 2021

Exclude cache pref last_run_time from export #772

Closed

Helium314 mentioned this pull request May 31, 2021

Fix Syncthing not running after boot when on schedule #815

Merged

Helium314 mentioned this pull request Jun 11, 2021

Sometimes doesn't stop after 5 minutes despite "Run according to time schedule" ticked #803

Closed

Helium314 mentioned this pull request Sep 7, 2021

Schedule a backup stop job when running on schedule (fixes #803) #837

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Time schedule: sync if conditions are fulfilled and last sync was more than 1h ago (fixes #592) #766

Time schedule: sync if conditions are fulfilled and last sync was more than 1h ago (fixes #592) #766

Helium314 commented Mar 21, 2021

Catfriend1 commented Mar 21, 2021

Catfriend1 commented Mar 21, 2021

Helium314 commented Mar 22, 2021

Helium314 commented Mar 22, 2021

Catfriend1 commented Mar 22, 2021

Helium314 commented Mar 22, 2021 •

edited

Catfriend1 commented Mar 22, 2021

Catfriend1 Mar 27, 2021

Helium314 Mar 27, 2021

Catfriend1 Mar 27, 2021

Helium314 Mar 27, 2021

Catfriend1 Mar 27, 2021

Helium314 Mar 27, 2021

Catfriend1 commented Mar 28, 2021 •

edited

Helium314 commented Mar 28, 2021

Catfriend1 commented Mar 28, 2021

Catfriend1 commented Mar 28, 2021

Catfriend1 commented Mar 28, 2021 •

edited

Helium314 commented Mar 28, 2021

Catfriend1 commented Apr 2, 2021

Catfriend1 commented Apr 2, 2021

Catfriend1 commented Apr 2, 2021 •

edited

Catfriend1 commented Apr 2, 2021

Catfriend1 commented Apr 2, 2021 •

edited

Catfriend1 Apr 2, 2021

Helium314 Apr 2, 2021

Catfriend1 commented Apr 2, 2021 •

edited

Catfriend1 commented Apr 2, 2021

Catfriend1 commented Apr 2, 2021 •

edited

Helium314 commented Apr 2, 2021

Catfriend1 commented Apr 2, 2021

Time schedule: sync if conditions are fulfilled and last sync was more than 1h ago (fixes #592) #766

Time schedule: sync if conditions are fulfilled and last sync was more than 1h ago (fixes #592) #766

Conversation

Helium314 commented Mar 21, 2021

Catfriend1 commented Mar 21, 2021

Catfriend1 commented Mar 21, 2021

Helium314 commented Mar 22, 2021

Helium314 commented Mar 22, 2021

Catfriend1 commented Mar 22, 2021

Helium314 commented Mar 22, 2021 • edited

Catfriend1 commented Mar 22, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Catfriend1 commented Mar 28, 2021 • edited

Helium314 commented Mar 28, 2021

Catfriend1 commented Mar 28, 2021

Catfriend1 commented Mar 28, 2021

Catfriend1 commented Mar 28, 2021 • edited

Helium314 commented Mar 28, 2021

Catfriend1 commented Apr 2, 2021

Catfriend1 commented Apr 2, 2021

Catfriend1 commented Apr 2, 2021 • edited

Catfriend1 commented Apr 2, 2021

Catfriend1 commented Apr 2, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Catfriend1 commented Apr 2, 2021 • edited

Catfriend1 commented Apr 2, 2021

Catfriend1 commented Apr 2, 2021 • edited

Helium314 commented Apr 2, 2021

Catfriend1 commented Apr 2, 2021

Helium314 commented Mar 22, 2021 •

edited

Catfriend1 commented Mar 28, 2021 •

edited

Catfriend1 commented Mar 28, 2021 •

edited

Catfriend1 commented Apr 2, 2021 •

edited

Catfriend1 commented Apr 2, 2021 •

edited

Catfriend1 commented Apr 2, 2021 •

edited

Catfriend1 commented Apr 2, 2021 •

edited