Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom export folder #18

Closed
TheLastProject opened this issue Oct 24, 2020 · 6 comments
Closed

Allow custom export folder #18

TheLastProject opened this issue Oct 24, 2020 · 6 comments
Labels
type: enhancement New feature or request

Comments

@TheLastProject
Copy link
Member

Issue by beng7
Sunday Dec 24, 2017 at 17:57 GMT
Originally opened as brarcher/loyalty-card-locker#168


Hi
Please allow user to be able to set custom Export folder as opposed to default /storage /emulated/0
--> e.g. to export to the nexcloud directory so cards are automatically backed up in nextcloud
Thanks a lot

@TheLastProject TheLastProject added the type: enhancement New feature or request label Oct 24, 2020
@TheLastProject
Copy link
Member Author

Comment by brarcher
Wednesday Dec 27, 2017 at 02:36 GMT


I think it is a good idea. I may not get to it right away, though. In the meantime, an alternative I can suggest is to share the backup data to another app and let it save it to the proper location. For example, Phone Saver (Google Play, F-Droid) will do just this. I have tested this app before and assisted with enhancements so it will work with my apps better.

@TheLastProject
Copy link
Member Author

Comment by beng7
Thursday Dec 28, 2017 at 10:33 GMT


Hi Branden,
Thanks for your reply.
Will try as you advised + still look to a future update with the option.
Let me thank you again for your excellent app + wish you a Happy New Year!
Cheers
ben

----- Original Message -----

From: "Branden Archer" notifications@github.com
To: "brarcher/loyalty-card-locker" loyalty-card-locker@noreply.github.com
Cc: "beng7" ben.gruselle@free.fr, "Author" author@noreply.github.com
Sent: Wednesday, 27 December, 2017 3:36:40 AM
Subject: Re: [brarcher/loyalty-card-locker] Allow custom export folder (#168)

I think it is a good idea. I may not get to it right away, though. In the meantime, an alternative I can suggest is to share the backup data to another app and let it save it to the proper location. For example, Phone Saver ( Google Play , F-Droid ) will do just this. I have tested this app before and assisted with enhancements so it will work with my apps better.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub , or mute the thread .

@TheLastProject
Copy link
Member Author

Comment by smoyth
Saturday Mar 10, 2018 at 13:58 GMT


+1

I might could contribute this one. Can you give an implementation pointers?

@TheLastProject
Copy link
Member Author

Comment by brarcher
Saturday Mar 10, 2018 at 18:57 GMT


@hooverlunch Recently I embedded a file picker into another of my apps. I think that it could be used here to specify the output folder. Take a look here for an example on adding the file picker, and documentation here.

My opinion is that from the ImportExportActivity if the user clicks on the Export button it should launch a file browser which asks to pick a directory. When the directory is selected the selected location is used to export the data. The filename itself can probably remain as LoyaltyCardKeychain.csv unless you feel strongly otherwise.

Note that there are unit tests which cover the import/export functionality and they would need to be updated as well.

@TheLastProject
Copy link
Member Author

Comment by natrius
Friday Apr 27, 2018 at 13:02 GMT


Yepp, duplicate, sorry for that. But yeah, custom folder appreciated - i might give phone saver a try too.

@TheLastProject
Copy link
Member Author

This have been added some releases ago, so I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant