Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom export folder #168

Open
beng7 opened this issue Dec 24, 2017 · 5 comments
Open

Allow custom export folder #168

beng7 opened this issue Dec 24, 2017 · 5 comments

Comments

@beng7
Copy link

beng7 commented Dec 24, 2017

Hi
Please allow user to be able to set custom Export folder as opposed to default /storage /emulated/0
--> e.g. to export to the nexcloud directory so cards are automatically backed up in nextcloud
Thanks a lot

@brarcher
Copy link
Owner

I think it is a good idea. I may not get to it right away, though. In the meantime, an alternative I can suggest is to share the backup data to another app and let it save it to the proper location. For example, Phone Saver (Google Play, F-Droid) will do just this. I have tested this app before and assisted with enhancements so it will work with my apps better.

@beng7
Copy link
Author

beng7 commented Dec 28, 2017 via email

@smoyte
Copy link

smoyte commented Mar 10, 2018

+1

I might could contribute this one. Can you give an implementation pointers?

@brarcher
Copy link
Owner

@hooverlunch Recently I embedded a file picker into another of my apps. I think that it could be used here to specify the output folder. Take a look here for an example on adding the file picker, and documentation here.

My opinion is that from the ImportExportActivity if the user clicks on the Export button it should launch a file browser which asks to pick a directory. When the directory is selected the selected location is used to export the data. The filename itself can probably remain as LoyaltyCardKeychain.csv unless you feel strongly otherwise.

Note that there are unit tests which cover the import/export functionality and they would need to be updated as well.

@natrius
Copy link

natrius commented Apr 27, 2018

Yepp, duplicate, sorry for that. But yeah, custom folder appreciated - i might give phone saver a try too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants