Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with "empty" helpers #2

Closed
Catobat opened this issue Feb 26, 2023 · 2 comments
Closed

Problems with "empty" helpers #2

Catobat opened this issue Feb 26, 2023 · 2 comments

Comments

@Catobat
Copy link
Owner

Catobat commented Feb 26, 2023

Certain settings combinations always fail on 0.7-dev and it's unclear why. It seems to have to do with the AccessDHC helper when it doesn't have any item requirements, which hints at potential issues with many other helpers, too.

Settings string to reproduce: NlgC5VAAQQgAeWFAEAQAAgAAAAQAAAgAQAAAAAAgABAAAAAAQAQAAAAAAAAAAAQAAgAAFB4=
The issue is that it can't place DHC Small Keys, likely because it thinks you can't access DHC.
This only happens when no element, sword, dungeon or figurine requirement is set. Enable either one and it works.
Set DHC to "Always Open" and it works again. Set it to "Never Open" and it fails again, but now with a "Randomization succeeded, but could not beat Vaati!" error. Again, only with no requirements.

It seems to have something to do with this line:
AccessDHC; Helper;; Helpers.GOTSWORDS GOTELEMENTS DHC_FIG DHC_AD
The issues arise if these 3 defines are all empty and the GOTSWORD helper is empty.
If you add some item requirement to the AccessDHC helper, it also generates.

From what I can tell, these issues were probably introduced with the recent caching changes.

@Catobat
Copy link
Owner Author

Catobat commented Feb 26, 2023

Appears to be fixed with 46fb5d4.

@Catobat
Copy link
Owner Author

Catobat commented Feb 26, 2023

Properly fixed by 728d26c.

@Catobat Catobat closed this as completed Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant