Skip to content

Commit

Permalink
Hotfix: app google sign in fixes + deploy fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
dmetzner committed May 21, 2020
1 parent fbbc5ff commit 0b75cad
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 9 deletions.
8 changes: 7 additions & 1 deletion deploy.php
Expand Up @@ -113,7 +113,7 @@
run('sudo /usr/sbin/service nginx restart');
});
task('restart:php-fpm', function () {
run('sudo /usr/sbin/service php7.3-fpm restart');
run('sudo /usr/sbin/service php7.4-fpm restart');
});
task('install:npm', function () {
cd('{{release_path}}');
Expand All @@ -124,6 +124,11 @@
run('grunt');
});

task('deploy:jwt', function () {
cd('{{release_path}}');
run('sh docker/app/init-jwt-config.sh');
});

/**
* Main task
*/
Expand All @@ -147,6 +152,7 @@
'database:migrate',
'install:npm',
'deploy:grunt',
'deploy:jwt',
'restart:nginx',
'restart:php-fpm',
'deploy:unlock',
Expand Down
12 changes: 4 additions & 8 deletions src/Catrobat/Services/OAuthService.php
Expand Up @@ -245,15 +245,15 @@ public function loginWithGoogleAction(Request $request): JsonResponse
'gplusUid' => $google_id,
]);

if (null !== $google_user)
if (null !== $google_user && null !== $google_id && '' !== $google_id)
{
$google_user->setUploadToken($this->token_generator->generateToken());
$this->user_manager->updateUser($google_user);
$retArray['token'] = $google_user->getUploadToken();
$retArray['username'] = $google_user->getUsername();
$this->setLoginOAuthUserStatusCode($retArray);
$retArray['statusCode'] = Response::HTTP_OK;
}
else
elseif (null !== $google_mail && '' !== $google_mail && null !== $google_username && '' !== $google_username)
{
/** @var User|null $user */
$user = $this->user_manager->findUserByEmail($google_mail);
Expand All @@ -265,6 +265,7 @@ public function loginWithGoogleAction(Request $request): JsonResponse
$this->user_manager->updateUser($user);
$retArray['token'] = $user->getUploadToken();
$retArray['username'] = $user->getUsername();
$retArray['statusCode'] = Response::HTTP_OK;
}
}

Expand Down Expand Up @@ -486,11 +487,6 @@ private function getAuthenticatedGoogleClientForGPlusUser(?User $user)
return $client;
}

private function setLoginOAuthUserStatusCode(array $retArray): void
{
$retArray['statusCode'] = StatusCode::OK;
}

/**
* @throws Exception
*/
Expand Down

0 comments on commit 0b75cad

Please sign in to comment.