SHARE-555 child restriction #4783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makne17
force-pushed
the
SHARE-555
branch
3 times, most recently
from
f7b07c9
to
e59ffd4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4783 +/- ##
=============================================
- Coverage 47.36% 41.15% -6.22%
- Complexity 5926 5940 +14
=============================================
Files 669 670 +1
Lines 20982 21057 +75
=============================================
- Hits 9939 8666 -1273
- Misses 11043 12391 +1348
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
makne17
force-pushed
the
SHARE-555
branch
3 times, most recently
from
8799d61
to
72b5a50
Compare
|
CAPI Model/ProjectResponse fehlt noch die Variable not_for_kids, hab sie zur catroweb.yaml file hinzugefügt wurde auch schon gemerged Edit: -> #4799 |
dmetzner
reviewed
Feb 28, 2024
translations/catroweb.en.yaml
Outdated
| @@ -1038,5 +1042,6 @@ maintenanceinformations: | |||
| feature_2: 'The Feature' | |||
| feature_3: 'The Feature' | |||
|
|
|||
|
|
|||
| MarkNotForKids: Mark as not for kids | |||
There was a problem hiding this comment.
Suggested change
| MarkNotForKids: Mark as not for kids | |
| MarkNotForKids: Mark as not safe for kids |
dmetzner
reviewed
Feb 28, 2024
translations/catroweb.en.yaml
Outdated
| @@ -1027,6 +1028,9 @@ media_library: | |||
|
|
|||
| snackbar: | |||
| project_not_found: 'The requested project is not available' | |||
| project_not_for_kids: 'The project was marked as not for kids!' | |||
There was a problem hiding this comment.
Suggested change
| project_not_for_kids: 'The project was marked as not for kids!' | |
| project_not_for_kids: 'The project was marked as safe not for kids!' |
dmetzner
reviewed
Feb 28, 2024
| if (null === $project) { | ||
| return $this->redirectToIndexOnError(); | ||
| } | ||
| if (2 == $project->getNotForKids()) { |
There was a problem hiding this comment.
Suggested change
| if (2 == $project->getNotForKids()) { | |
| if (<const>== $project->getNotForKids()) { |
Use constants please
|
@makne17 api is now merged, just rebase :) |
added not for kids property to admin panel added button to change not for kids flag added not for kids flag in meta data
dmetzner
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added not for kids property to admin panel
added button to change not for kids flag
added not for kids flag in meta data
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.
SHARE-666 The devils ticketCode Reviewsection in JiraAdditional Description
TODO: Add additional information that is not in your commit-message hereTests - additional information
TODO: add additional information about testruns here