SHARE-350 Remove unused OAuth stuff #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-removed unused old OAuth stuff from register.js -removed unused old OAuth stuff from templates -removed old OAuth test cases -removed old OAuth translations
Codecov Report
@@ Coverage Diff @@
## develop #782 +/- ##
=============================================
- Coverage 40.19% 37.25% -2.95%
- Complexity 4765 4847 +82
=============================================
Files 559 566 +7
Lines 14702 14999 +297
=============================================
- Hits 5910 5588 -322
- Misses 8792 9411 +619
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
dmetzner
reviewed
Jul 30, 2020
| @@ -1,4 +1,4 @@ | |||
| {# needed for Google Sign #} | |||
| {# needed for OAuth Sign in #} | |||
| <head> | |||
There was a problem hiding this comment.
have you checked if we still need this font?
There was a problem hiding this comment.
I added that font because of the google branding guidelines. So that should be fine
dmetzner
requested changes
Jul 30, 2020
dmetzner
approved these changes
Aug 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-removed unused old OAuth stuff from register.js
-removed unused old OAuth stuff from templates
-removed old OAuth test cases
-removed old OAuth translations
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.
SHARE-666 The devils ticketCode Reviewsection in JiraAdditional Description
TODO: Add additional information that is not in your commit-message hereTests - additional information
TODO: add additional information about testruns here