Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHARE-371 Click statistics adapt to new design #830

Conversation

leno12
Copy link
Contributor

@leno12 leno12 commented Aug 14, 2020

-fixed click statistics on the homepage for the project page we need to wait for the new Capi release and will leave that for a new ticket
-refactored test case
-for recommended projects we need to wait for the new Capi routes


Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name and id of the Jira ticket in the PR’s title eg.: SHARE-666 The devils ticket
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no warnings and errors
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Verify that all tests are passing, if not please state the test cases in the section below
  • Perform a self-review of the changes
  • Stick to the project’s git workflow (rebase and squash your commits)
  • Verify that your changes do not have any conflicts with the base branch
  • Put your ticket into the Code Review section in Jira
  • Post a message in the #catroweb Slack channel and ask for a code reviewer

Additional Description

TODO: Add additional information that is not in your commit-message here

Tests - additional information

TODO: add additional information about testruns here

@leno12 leno12 marked this pull request as draft August 14, 2020 12:00
@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #830 into develop will increase coverage by 2.93%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #830      +/-   ##
=============================================
+ Coverage      40.35%   43.28%   +2.93%     
  Complexity      4279     4279              
=============================================
  Files            555      555              
  Lines          14862    14862              
=============================================
+ Hits            5997     6433     +436     
+ Misses          8865     8429     -436     
Flag Coverage Δ Complexity Δ
#behat 41.85% <ø> (+2.98%) 4279.00 <ø> (ø)
#phpunit 6.92% <ø> (ø) 4279.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/Catrobat/Services/ImageRepository.php 41.26% <0.00%> (+3.17%) 19.00% <0.00%> (ø%)
src/Entity/Program.php 75.00% <0.00%> (+3.52%) 119.00% <0.00%> (ø%)
src/Catrobat/Services/ScreenshotRepository.php 71.32% <0.00%> (+4.41%) 37.00% <0.00%> (ø%)
src/Entity/User.php 33.81% <0.00%> (+5.03%) 59.00% <0.00%> (ø%)
src/Entity/Tag.php 53.33% <0.00%> (+6.66%) 15.00% <0.00%> (ø%)
src/Repository/ProgramLikeRepository.php 36.36% <0.00%> (+6.81%) 15.00% <0.00%> (ø%)
src/Repository/ProgramRepository.php 48.79% <0.00%> (+7.05%) 85.00% <0.00%> (ø%)
src/Entity/Extension.php 48.00% <0.00%> (+8.00%) 13.00% <0.00%> (ø%)
src/Catrobat/Twig/AppExtension.php 47.79% <0.00%> (+8.80%) 55.00% <0.00%> (ø%)
src/Entity/ClickStatistic.php 9.37% <0.00%> (+9.37%) 32.00% <0.00%> (ø%)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f71d06...6210c59. Read the comment docs.

-fixed click statistics
-refactored test case
-for recommended projects we need to wait for the new Capi routes
@leno12 leno12 force-pushed the SHARE-371_Click_Statistics_Adapt_to_new_Design branch from dde8892 to 6210c59 Compare August 14, 2020 13:28
@leno12 leno12 marked this pull request as ready for review August 15, 2020 08:45
@dmetzner dmetzner self-requested a review August 15, 2020 08:52
@dmetzner dmetzner merged commit 624c6d4 into Catrobat:develop Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants