Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHARE-40 AdminDFClickStatistics Refactoring #837

Merged

Conversation

leno12
Copy link
Contributor

@leno12 leno12 commented Aug 16, 2020

-removed ip adress, country code, country name and edit button
-added test case


Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name and id of the Jira ticket in the PR’s title eg.: SHARE-666 The devils ticket
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no warnings and errors
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Verify that all tests are passing, if not please state the test cases in the section below
  • Perform a self-review of the changes
  • Stick to the project’s git workflow (rebase and squash your commits)
  • Verify that your changes do not have any conflicts with the base branch
  • Put your ticket into the Code Review section in Jira
  • Post a message in the #catroweb Slack channel and ask for a code reviewer

Additional Description

TODO: Add additional information that is not in your commit-message here

Tests - additional information

TODO: add additional information about testruns here

@leno12 leno12 force-pushed the SHARE-40_AdminDFclickStatistics_Refactoring branch from 9bd838d to ff03484 Compare August 16, 2020 12:21
-removed ip adress, country code and country name
-added test case
@leno12 leno12 force-pushed the SHARE-40_AdminDFclickStatistics_Refactoring branch from ff03484 to b69c4a6 Compare August 16, 2020 16:31
@dmetzner dmetzner merged commit 151673c into Catrobat:develop Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants