SHARE-380 Correct links at bottom of pages #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leno12
force-pushed
the
SHARE-380_Correct_links_at_bottom_of_pages
branch
from
1d2fc0d
to
3335ff6
Compare
dmetzner
requested changes
Aug 17, 2020
There was a problem hiding this comment.
https://pr838-web.catrobat.ist.tugraz.at/app/privacypolicy
Footer -> privacy policy..... the page is not optimized for direct viewing.
It was made to be shown in the privacy policy pop up......
If we have to show the privacy policy, we have to create a new template that uses this privacy policy but extends the base layout
| @@ -4,4 +4,4 @@ | |||
| Pocket Alice Website | |||
| {% endblock %} | |||
|
|
|||
| {% set google_play_url = "https://play.google.com/store/apps/details?id=org.catrobat.catroid" %} | |||
| {% set google_play_url = "https://catrob.at/gp" %} | |||
There was a problem hiding this comment.
if all have the same URL. remove the variable overwrites from the themes and just set a default value.
templates/Default/footer.html.twig
Outdated
| @@ -6,19 +6,19 @@ | |||
| <h3>{{ "footer.usefulLinks"|trans({}, "catroweb") }}</h3> | |||
| <ul class="list-vertical"> | |||
| <li> | |||
| <a href="{{ url('catrobat_web_help') }}">{{ "tutorials"|trans({}, "catroweb") }}</a> | |||
| <a id="help" href="https://catrob.at/ShareHelp">{{ "tutorials"|trans({}, "catroweb") }}</a> | |||
There was a problem hiding this comment.
not sure about this one.... Being on a test server brings you to the share server....
leno12
force-pushed
the
SHARE-380_Correct_links_at_bottom_of_pages
branch
from
3335ff6
to
7e64d81
Compare
-Changed links in the footer -Added Test case
leno12
force-pushed
the
SHARE-380_Correct_links_at_bottom_of_pages
branch
from
7e64d81
to
faf7b7d
Compare
dmetzner
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Changed links in the footer
-Added Test case
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.
SHARE-666 The devils ticketCode Reviewsection in JiraAdditional Description
TODO: Add additional information that is not in your commit-message hereTests - additional information
TODO: add additional information about testruns here