Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHARE-370 Homepage Recommendations #857

Merged

Conversation

leno12
Copy link
Contributor

@leno12 leno12 commented Aug 23, 2020

-Implemented API call for homepage recommended programs
-Wrote API test cases
-Enabled recommended projects on the homepage


Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name and id of the Jira ticket in the PR’s title eg.: SHARE-666 The devils ticket
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no warnings and errors
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Verify that all tests are passing, if not please state the test cases in the section below
  • Perform a self-review of the changes
  • Stick to the project’s git workflow (rebase and squash your commits)
  • Verify that your changes do not have any conflicts with the base branch
  • Put your ticket into the Code Review section in Jira
  • Post a message in the #catroweb Slack channel and ask for a code reviewer

Additional Description

TODO: Add additional information that is not in your commit-message here

Tests - additional information

TODO: add additional information about testruns here

@leno12 leno12 marked this pull request as draft August 23, 2020 18:15
@leno12 leno12 force-pushed the SHARE-370_Homepage_Recommendations branch 5 times, most recently from 3b1ae9c to 67ac8e2 Compare August 26, 2020 08:37
@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #857 into develop will increase coverage by 1.25%.
The diff coverage is 43.47%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #857      +/-   ##
=============================================
+ Coverage      43.43%   44.68%   +1.25%     
- Complexity      4309     4322      +13     
=============================================
  Files            569      569              
  Lines          15117    14732     -385     
=============================================
+ Hits            6566     6583      +17     
+ Misses          8551     8149     -402     
Flag Coverage Δ Complexity Δ
#behat 43.01% <43.47%> (+1.20%) 4322.00 <39.00> (+13.00)
#phpunit 7.71% <0.00%> (-0.02%) 4322.00 <39.00> (+13.00) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/Api/AuthenticationApi.php 50.00% <0.00%> (-7.15%) 4.00 <1.00> (+1.00) ⬇️
.../Catrobat/RecommenderSystem/RecommenderManager.php 25.00% <34.28%> (+1.14%) 70.00 <32.00> (+9.00)
src/Api/ProjectsApi.php 93.47% <75.00%> (+0.24%) 29.00 <2.00> (+3.00)
src/Repository/ProgramRepository.php 53.52% <100.00%> (+4.71%) 85.00 <4.00> (ø)
src/Admin/RudewordAdmin.php 0.00% <0.00%> (ø) 5.00% <0.00%> (ø%)
src/Admin/CategoriesAdmin.php 0.00% <0.00%> (ø) 4.00% <0.00%> (ø%)
src/Admin/MediaPackageAdmin.php 0.00% <0.00%> (ø) 3.00% <0.00%> (ø%)
src/Admin/NotificationAdmin.php 0.00% <0.00%> (ø) 6.00% <0.00%> (ø%)
src/Admin/AllExtensionsAdmin.php 0.00% <0.00%> (ø) 4.00% <0.00%> (ø%)
src/Admin/ReportedUsersAdmin.php 0.00% <0.00%> (ø) 8.00% <0.00%> (ø%)
... and 117 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1ead4f...cb4c541. Read the comment docs.

@leno12 leno12 force-pushed the SHARE-370_Homepage_Recommendations branch 3 times, most recently from 684365e to b4c62f1 Compare September 2, 2020 12:34
@leno12 leno12 marked this pull request as ready for review September 2, 2020 12:36
@leno12 leno12 force-pushed the SHARE-370_Homepage_Recommendations branch from b4c62f1 to fc86334 Compare September 2, 2020 12:41
@dmetzner dmetzner self-requested a review September 20, 2020 07:16
-Implemented API call for homepage recommended programs
-Wrote API test cases
-Enabled recommended projects on the homepage
-Refactored behat test case for recommendd projects
-Refactored clikc statistics test case for recommended projects on the homepage
@dmetzner dmetzner force-pushed the SHARE-370_Homepage_Recommendations branch from fc86334 to cb4c541 Compare September 20, 2020 07:36
@dmetzner dmetzner merged commit b39f102 into Catrobat:develop Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants