CATTY-3 Show detail pages of projects on share in webview #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-herold
requested changes
Feb 13, 2019
There was a problem hiding this comment.
Looks already very good!
Please have a look at the following scenario:
Project detail page, internet drops, user clicks download.
In the above scenario an alert gets displayed which is great, but after dismissing the alert, the loading screen does disappear.
Please also replace checkmark.png with kBDKNotifyHUDCheckmarkImageName (has been there already).
src/Catty/ViewController/Download/SearchStore/SearchStoreViewController.swift
Outdated
Show resolved
Hide resolved
...atty/ViewController/Download/FeaturedProjects/FeaturedProjectsStoreTableViewController.swift
Outdated
Show resolved
Hide resolved
src/Catty/ViewController/Download/ChartProjects/ChartProjectsStoreViewController.swift
Outdated
Show resolved
Hide resolved
m-herold
reviewed
Feb 13, 2019
|
Closing for now, please resubmit from your fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.