Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAINTROID-416 Layout gets broken when changing tools #1128

Merged
merged 1 commit into from Jul 13, 2022
Merged

PAINTROID-416 Layout gets broken when changing tools #1128

merged 1 commit into from Jul 13, 2022

Conversation

FromG
Copy link
Contributor

@FromG FromG commented Jun 30, 2022 •
edited

-implemented a line in switch Tools in the MainActivityPresenter where the keyboard will be hidden if it is still shown.

https://jira.catrob.at/browse/PAINTROID-416

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

@FromG
PAINTROID-416 Layout gets broken when changing tools
efc276d 
-implemented a line in switch Tools in the MainActivityPresenter where the keyboard will be hidden if it is still shown.

-deleted the else if since another bug is also fixed with directly inputting a text into the tool without clicking on the field produced the same bug.
Electronix1337
Electronix1337 approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@Electronix1337 Electronix1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, layout is not broken after switching from one tool to another while the keyboard is displayed.

@CodeChamp-SS
Copy link
Member

LGTM!

@CodeChamp-SS CodeChamp-SS merged commit 09cfbb4 into Catrobat:develop Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Electronix1337 Electronix1337 Electronix1337 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@FromG @CodeChamp-SS @Electronix1337