Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAINTROID-445 Give feedback of changed canvas when changing tools #1130

Conversation

Electronix1337
Copy link
Contributor

@Electronix1337 Electronix1337 commented Jul 12, 2022

Rewrote some parts of switchTool structure in order to highlight(set the color border to orange) the box (of BaseToolWithRectangleShape) for 300 milliseconds before actually switching the tool.

https://jira.catrob.at/browse/PAINTROID-445

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

@Electronix1337 Electronix1337 force-pushed the PAINTROID-445_Give_feedback_of_changed_canvas_when_changing_tools branch 3 times, most recently from d066b47 to fa07417 Compare July 12, 2022 13:31
Copy link
Contributor

@FromG FromG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on jenkins 2 additional testcases fail when testing with catroid.
However as i could not reproduce them locally i do not know if it is a ticket depending error.

lgtm.

@Electronix1337 Electronix1337 force-pushed the PAINTROID-445_Give_feedback_of_changed_canvas_when_changing_tools branch 4 times, most recently from aa272a3 to f452cb7 Compare July 22, 2022 09:40
Copy link
Member

@CodeChamp-SS CodeChamp-SS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about this approach? This would help in utilizing the already implemented highlight functionality and avoiding use of runBlocking :)

@Electronix1337 Electronix1337 force-pushed the PAINTROID-445_Give_feedback_of_changed_canvas_when_changing_tools branch 9 times, most recently from a1bb77f to 2725c9d Compare July 27, 2022 08:07
Rewrote some parts of switchTool structure in order to highlight(set the color border to orange) the box (of BaseToolWithRectangleShape) for 300 milliseconds before actually switching the tool.
@Electronix1337 Electronix1337 force-pushed the PAINTROID-445_Give_feedback_of_changed_canvas_when_changing_tools branch from 2725c9d to 830ed2d Compare July 27, 2022 08:18
Copy link
Member

@CodeChamp-SS CodeChamp-SS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The changes work as expected.

@CodeChamp-SS CodeChamp-SS merged commit cbbf499 into Catrobat:develop Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants