Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAINTROID-503 Fix LandscapeIntegrationTests #1280

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

exland
Copy link
Contributor

@exland exland commented May 24, 2023

Fixed the Testcase that keep failing on jenkins Ticket

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

@exland exland changed the title Paintroid-503 Fixed the LandscapeIntegrationTest PAINTROID-503 Fix LandscapeIntegrationTests May 24, 2023
@exland exland force-pushed the PAINTROID-503 branch 3 times, most recently from 32e1287 to 67bb031 Compare May 24, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant