Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAINTROID-299 Refactor SaveImageAsync, CreateFileAsync #948

Closed
wants to merge 1 commit into from

Conversation

CodeChamp-SS
Copy link
Member

@CodeChamp-SS CodeChamp-SS commented Jun 26, 2021

Files that were refactored:

  1. SaveImageAsync
  2. CreateFileAsync
  3. MainActivityInteractor
  4. MenuFileActivityIntegrationTest
  5. OraFileFormatIntegrationTest

Replaced AsyncTask with Coroutines in SaveImageAsync and CreateFileAsync classes, and renamed them to SaveImage, CreateFile respectively. Added runBlocking to the respective test usages of these files in MenuFileActivityIntegrationTest and OraFileFormatIntegrationTest classes.

https://jira.catrob.at/browse/PAINTROID-299

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

@CodeChamp-SS CodeChamp-SS force-pushed the PAINTROID-299 branch 4 times, most recently from 7da8c44 to c4159fe Compare June 26, 2021 18:28
…yInteractor, MenuFileActivityIntegrationTest, OraFileFormatIntegrationTest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants