Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added repo badges in the readme #69

Merged
merged 15 commits into from
Jun 7, 2023
Merged

Added repo badges in the readme #69

merged 15 commits into from
Jun 7, 2023

Conversation

mukul314
Copy link
Contributor

@mukul314 mukul314 commented Jun 1, 2023 •
edited

Related Issue(s)

Closes #48

Proposed Changes

Added repo badges in readme

Type of Change

  • New Feature (Landing Page)
  • New Feature (App)
  • Bug (Landing Page)
  • Bug (App)
  • New Component (App)
  • Enhancement
  • Documentation / ReadMe / Workflows
  • Other (If not in above options):

Your Idea for Level (GSSoC)

  • Level 1
  • Level 2
  • Level 3

Screenshots (if applicable)

Additional Notes

@github-actions github-actions bot added the gssoc23 This is label for GirlScript Summer of Code 2023 label Jun 1, 2023
@AmanJain18
Copy link
Collaborator

@mukul314 Edit this PR template and rewrite it properly

@mukul314
Copy link
Contributor Author

mukul314 commented Jun 4, 2023

@mukul314 Edit this PR template and rewrite it properly

@AmanJain18 done!

@AmanJain18
Copy link
Collaborator

Also fix the title bro.

praveenscience
praveenscience requested changes Jun 4, 2023
View reviewed changes
README.md Outdated
Comment on lines 1 to 17
<div align="center">
<img src="https://img.shields.io/badge/Built%20with-Love-red.svg?style=for-the-badge" />
<img src="https://img.shields.io/badge/Uses-Brains-blue.svg?style=for-the-badge" />
<img src="https://img.shields.io/badge/Powered%20by-Responsibility-orange.svg?style=for-the-badge" />
<br/>
<img src="https://img.shields.io/github/repo-size/CatsInTech/GitHub-ReadMe.svg?style=for-the-badge" />
<a href="LICENSE"><img src="https://img.shields.io/badge/License-MIT-blue.svg?style=for-the-badge" /></a>
<img src="https://img.shields.io/github/issues-closed-raw/CatsInTech/GitHub-ReadMe.svg?style=for-the-badge" />
<img src="https://img.shields.io/github/issues/CatsInTech/GitHub-ReadMe.svg?style=for-the-badge" />
<img src="https://img.shields.io/github/issues-closed/CatsInTech/GitHub-ReadMe.svg?style=for-the-badge" />
<img src="https://img.shields.io/github/stars/CatsInTech/GitHub-ReadMe.svg?style=social&label=Stars" />
<img src="https://img.shields.io/github/forks/CatsInTech/GitHub-ReadMe.svg?style=social" />
<img src="https://img.shields.io/github/issues-pr/CatsInTech/GitHub-ReadMe.svg?style=for-the-badge" />
<img src="https://img.shields.io/github/last-commit/CatsInTech/GitHub-ReadMe.svg?style=for-the-badge" />
<img src="https://img.shields.io/github/contributors/CatsInTech/GitHub-ReadMe.svg?style=for-the-badge" />
<img src="https://img.shields.io/github/issues-pr-closed-raw/CatsInTech/GitHub-ReadMe.svg?style=for-the-badge" />
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have this aligned properly, thanks! 😊

@mukul314 mukul314 changed the title Fixes #48 Added repo badges in the readme Jun 4, 2023
praveenscience
praveenscience requested changes Jun 4, 2023
View reviewed changes
README.md Outdated
<img src="https://img.shields.io/github/contributors/CatsInTech/GitHub-ReadMe.svg?style=for-the-badge" />
<img src="https://img.shields.io/github/issues-pr-closed-raw/CatsInTech/GitHub-ReadMe.svg?style=for-the-badge" />
<div style="text-align: center;">
<p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we require the <p> tag?

README.md Outdated
Comment on lines 3 to 18
<img src="https://img.shields.io/badge/Built%20with-Love-red.svg?style=for-the-badge" />
<img src="https://img.shields.io/badge/Uses-Brains-blue.svg?style=for-the-badge" />
<img src="https://img.shields.io/badge/Powered%20by-Responsibility-orange.svg?style=for-the-badge" />
<br/>
<img src="https://img.shields.io/github/repo-size/CatsInTech/GitHub-ReadMe.svg?style=for-the-badge" />
<a href="LICENSE"><img src="https://img.shields.io/badge/License-MIT-blue.svg?style=for-the-badge" /></a>
<img src="https://img.shields.io/github/issues-closed-raw/CatsInTech/GitHub-ReadMe.svg?style=for-the-badge" />
<img src="https://img.shields.io/github/issues/CatsInTech/GitHub-ReadMe.svg?style=for-the-badge" />
<img src="https://img.shields.io/github/issues-closed/CatsInTech/GitHub-ReadMe.svg?style=for-the-badge" />
<img src="https://img.shields.io/github/stars/CatsInTech/GitHub-ReadMe.svg?style=social&label=Stars" />
<img src="https://img.shields.io/github/forks/CatsInTech/GitHub-ReadMe.svg?style=social" />
<img src="https://img.shields.io/github/issues-pr/CatsInTech/GitHub-ReadMe.svg?style=for-the-badge" />
<img src="https://img.shields.io/github/last-commit/CatsInTech/GitHub-ReadMe.svg?style=for-the-badge" />
<img src="https://img.shields.io/github/contributors/CatsInTech/GitHub-ReadMe.svg?style=for-the-badge" />
<img src="https://img.shields.io/github/issues-pr-closed-raw/CatsInTech/GitHub-ReadMe.svg?style=for-the-badge" />
</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can you move it below the ToC?

@praveenscience praveenscience mentioned this pull request Jun 4, 2023
Closed
praveenscience
praveenscience requested changes Jun 5, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@AmanJain18
Copy link
Collaborator

For just adding badges in readme, this much Commits? 😂🤦

@praveenscience
Copy link
Member

@AmanJain18 It's alright, @mukul314 is trialling a lot of things and then again, getting merge conflicts and stuff! 😅

@AmanJain18
Copy link
Collaborator

Ya No Issues. 😊🤗

@mukul314
Copy link
Contributor Author

mukul314 commented Jun 6, 2023 •
edited

For just adding badges in readme, this much Commits? 😂🤦

@AmanJain18 🤣 , I know that this issue has been stretched a bit, but I learned a lot from it also. Along with that, I would also like to thank amazing maintainers like @praveenscience and you who have patiently reviewed each and every request and responded timely. The guidance that I received is remarkable. Thanks a lot for that 😄 .

As for the changes, I will replace the <br> with <br /> but can you tell me how to keep that indentation part? I guess I am not getting what you want to convey 😅 .

praveenscience
praveenscience approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@praveenscience praveenscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, @mukul314, I have made it myself, check it out from the changes! 💪

README.md Outdated Show resolved Hide resolved
@praveenscience praveenscience merged commit 80a3d26 into CatsInTech:main Jun 7, 2023
@AmanJain18 AmanJain18 added the level1 For Documentation and small line code Merge - 10 Point label Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveenscience praveenscience praveenscience approved these changes

Assignees

@mukul314 mukul314

Labels
gssoc23 This is label for GirlScript Summer of Code 2023 level1 For Documentation and small line code Merge - 10 Point
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📚 [Documentation] - Adding repo badges in README.
3 participants
@mukul314 @AmanJain18 @praveenscience